From: Michael Schmitz <schmitzmic@gmail.com>
To: linux-block@vger.kernel.org, axboe@kernel.dk
Cc: linux-m68k@vger.kernel.org, geert@linux-m68k.org
Subject: [PATCH v6 0/2]
Date: Sun, 14 Oct 2018 17:48:33 +1300 [thread overview]
Message-ID: <1539492515-1782-1-git-send-email-schmitzmic@gmail.com> (raw)
and yet another new version of the Amiga RDB partition table patch.
I've split off the part fixing the incorrect use of signed int
for partition start address and size as separate patch. It does fix the
bug that Martin Steigerwald reported six years ago for a 2 TB disk.
I have tested this patch with the identical RDB partition data that
Martin saw the bug with. I have incorporated Andreas' feedback on proper
use of casts to avoid integer overflow in this version.
The simple fix still leaves ample room for overflows in calculating start
address and size of a RDB partition, though such overflows should only be
seen in rather unusual cases. To address these potential overflows, checks
are added in the second patch of this series. Again, misuse of casts have
been corrected, and yet another (highly unlikely) potential 32 bit
multiplication overflow caused by use of signed int instead of sector
(spotted by Geert Uytterhoeven) has been fixed and a check has been added
in this version.
I've added Geert's Reviewed-by tag to patch 1,as there were no further
changes to that patch.
Cheers,
Michael
next reply other threads:[~2018-10-14 4:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-14 4:48 Michael Schmitz [this message]
2018-10-14 4:48 ` [PATCH v6 1/2] block: fix signed int overflow in Amiga partition support Michael Schmitz
2018-10-14 4:48 ` [PATCH v6 2/2] block: add overflow checks for " Michael Schmitz
2018-10-14 10:42 ` Geert Uytterhoeven
2018-10-15 0:11 ` Michael Schmitz
2018-10-14 4:51 ` [PATCH v6 0/2] Amiga RDB partition support fixes Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539492515-1782-1-git-send-email-schmitzmic@gmail.com \
--to=schmitzmic@gmail.com \
--cc=axboe@kernel.dk \
--cc=geert@linux-m68k.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).