Re: [PATCH 08/28] scsi: kill off the legacy IO path

[Bart Van Assche <bvanassche@acm.org>]

On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote:
> @@ -3265,25 +3261,17 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
>  	    base_vha->mgmt_svr_loop_id, host->sg_tablesize);
>  
>  	if (ha->mqenable) {
> -		bool mq = false;
>  		bool startit = false;
>  
> -		if (QLA_TGT_MODE_ENABLED()) {
> -			mq = true;
> +		if (QLA_TGT_MODE_ENABLED())
>  			startit = false;
> -		}
>  
> -		if ((ql2x_ini_mode == QLA2XXX_INI_MODE_ENABLED) &&
> -		    shost_use_blk_mq(host)) {
> -			mq = true;
> +		if (ql2x_ini_mode == QLA2XXX_INI_MODE_ENABLED)
>  			startit = true;
> -		}
>  
> -		if (mq) {
> -			/* Create start of day qpairs for Block MQ */
> -			for (i = 0; i < ha->max_qpairs; i++)
> -				qla2xxx_create_qpair(base_vha, 5, 0, startit);
> -		}
> +		/* Create start of day qpairs for Block MQ */
> +		for (i = 0; i < ha->max_qpairs; i++)
> +			qla2xxx_create_qpair(base_vha, 5, 0, startit);
>  	}
>  
>  	if (ha->flags.running_gold_fw)

(+Himanshu)

Since I'm not sure that "mq" in the above code refers to "scsi-mq" nor that it
refers to "blk-mq", I'm not sure the above changes should be included in this
patch. Himanshu, can you have a look?

> +static ssize_t
> +show_use_blk_mq(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> +	return snprintf(buf, 20, "1\n");
> +}
> +static DEVICE_ATTR(use_blk_mq, S_IRUGO, show_use_blk_mq, NULL);

The pattern "snprintf(buf, 20, ...)" looks like cargo-cult programming to me.
Please consider changing "snprintf(buf, 20, " into "sprintf(buf, ".

Thanks,

Bart.