From: Bart Van Assche <bvanassche@acm.org>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH blktests -v2] Fix build failure for discontiguous-io on 32-bit platforms
Date: Tue, 30 Oct 2018 10:19:31 -0700 [thread overview]
Message-ID: <1540919971.196084.113.camel@acm.org> (raw)
In-Reply-To: <20181030160223.GA6236@thunk.org>
On Tue, 2018-10-30 at 12:02 -0400, Theodore Y. Ts'o wrote:
> On Tue, Oct 30, 2018 at 08:02:55AM -0700, Bart Van Assche wrote:
> > Details about how the build fails on 32-bit systems would have been welcome
> > in the commit message. Anyway:
> >
> > Reviewed-by: Bart Van Assche <bvanassche@acm.org>
>
> For the record, here's the failure. It's the usual incomprehensible
> C++ error reporting. :-)
>
> [ ... ]
> discontiguous-io.cpp: In function 'int main(int, char**)':
> discontiguous-io.cpp:294:34: error: no matching function for call to 'min(long unsigned int, size_t)'
> std::min(4ul, len - i * 4));
> ^
> [ ... ]
Thanks Ted for having provided the full compiler output. However, I don't
think that the entire error message should go in the commit message. To me,
the part of the compiler error message I cited tells the whole story :-)
Bart.
prev parent reply other threads:[~2018-10-31 2:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 14:36 [PATCH blktests -v2] Fix build failure for discontiguous-io on 32-bit platforms Theodore Ts'o
2018-10-30 15:02 ` Bart Van Assche
2018-10-30 16:02 ` Theodore Y. Ts'o
2018-10-30 17:19 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540919971.196084.113.camel@acm.org \
--to=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).