From: Bart Van Assche <bvanassche@acm.org>
To: Weiping Zhang <zhangweiping@didiglobal.com>, axboe@kernel.dk
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH v2] block: add documentation for io_timeout
Date: Thu, 29 Nov 2018 08:41:54 -0800 [thread overview]
Message-ID: <1543509714.185366.134.camel@acm.org> (raw)
In-Reply-To: <20181129102237.GA29592@192.168.3.9>
On Thu, 2018-11-29 at 18:22 +0800, Weiping Zhang wrote:
> add documentation for /sys/block/<disk>/queue/io_timeout
Patch descriptions should consist of full sentences. That means that these
should start with a capital letter and end with a period.
> +
> +What: /sys/block/<disk>/queue/io_timeout
> +Date: November 2018
> +Contact: Weiping Zhang <zhangweiping@didiglobal.com>
> +Description:
> + io_timeout is the timeout in milliseconds of a request in
> + block layer. The block layer will start a timer when low
> + level device driver start the request, and cancel timer
> + when request completes.
The grammar of that explanation needs to be improved ... I can spot three
grammatical issues.
Thanks,
Bart.
prev parent reply other threads:[~2018-11-29 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 10:22 [PATCH v2] block: add documentation for io_timeout Weiping Zhang
2018-11-29 16:41 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543509714.185366.134.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=zhangweiping@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).