From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>, Ming Lei <tom.leiming@gmail.com>,
linux-block <linux-block@vger.kernel.org>,
Omar Sandoval <osandov@fb.com>
Subject: Re: block: sbitmap related lockdep warning
Date: Mon, 03 Dec 2018 16:31:28 -0800 [thread overview]
Message-ID: <1543883488.185366.176.camel@acm.org> (raw)
In-Reply-To: <879e4f73-caa0-93e0-a6c3-3d53d1962cee@kernel.dk>
On Mon, 2018-12-03 at 15:24 -0700, Jens Axboe wrote:
> On 12/3/18 3:02 AM, Ming Lei wrote:
> > Hi,
> >
> > Just found there is sbmitmap related lockdep warning, not take a close
> > look yet, maybe
> > it is caused by recent sbitmap change.
> >
> > [1] test
> > - modprobe null_blk queue_mode=2 nr_devices=4 shared_tags=1
> > submit_queues=1 hw_queue_depth=1
> > - then run fio on the 4 null_blk devices
>
> This is a false positive - lockdep thinks that ->swap_lock needs to be
> IRQ safe since it's called with IRQs disabled from the
> blk_mq_mark_tag_wait() path. But we never grab the lock from IRQ
> context. I wonder how to teach lockdep about that...
There is probably a better solution, but one possible solution is to disable
lockdep checking for swap_lock by using lockdep_set_novalidate_class().
Bart.
next prev parent reply other threads:[~2018-12-04 0:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 10:02 block: sbitmap related lockdep warning Ming Lei
2018-12-03 22:24 ` Jens Axboe
2018-12-04 0:31 ` Bart Van Assche [this message]
2018-12-04 0:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543883488.185366.176.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox