From: Bart Van Assche <bvanassche@acm.org>
To: Weiping Zhang <zhangweiping@didiglobal.com>, axboe@kernel.dk
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] block: get rid of BLK_MAX_TIMEOUT
Date: Wed, 05 Dec 2018 07:58:59 -0800 [thread overview]
Message-ID: <1544025539.185366.224.camel@acm.org> (raw)
In-Reply-To: <997df532a176a435c3581ce180f318a298084393.1544023832.git.zhangweiping@didiglobal.com>
On Wed, 2018-12-05 at 23:37 +0800, Weiping Zhang wrote:
> @@ -130,7 +119,7 @@ void blk_add_timer(struct request *req)
> * than an existing one, modify the timer. Round up to next nearest
> * second.
> */
> - expiry = blk_rq_timeout(round_jiffies_up(expiry));
> + expiry = round_jiffies_up(expiry);
If you would have read the comment above this code, you would have known
that this patch does not do what you think it does and additionally that
it introduces a regression.
Bart.
next prev parent reply other threads:[~2018-12-05 15:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 15:36 [PATCH 0/2] get rid of BLK_MAX_TIMEOUT Weiping Zhang
2018-12-05 15:37 ` [PATCH 1/2] block: " Weiping Zhang
2018-12-05 15:58 ` Bart Van Assche [this message]
2018-12-06 14:18 ` Weiping Zhang
2018-12-06 16:14 ` Bart Van Assche
2018-12-05 15:38 ` [PATCH 2/2] block: add BLK_DEF_TIMEOUT Weiping Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544025539.185366.224.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=zhangweiping@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).