From: Bart Van Assche <bvanassche@acm.org>
To: Weiping Zhang <zhangweiping@didiglobal.com>, axboe@kernel.dk
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH v3] block: add documentation for io_timeout
Date: Thu, 06 Dec 2018 08:19:34 -0800 [thread overview]
Message-ID: <1544113174.185366.240.camel@acm.org> (raw)
In-Reply-To: <20181205141701.GA33910@192.168.3.9>
On Wed, 2018-12-05 at 22:17 +0800, Weiping Zhang wrote:
> +Description:
> + io_timeout is a request’s timeouts at block layer in
> + milliseconds. When the underlying driver starts processing
> + a request, the generic block layer will start a timer, if
> + this request cannot be completed in io_timeout milliseconds,
> + a timeout event will occur.
Sorry but I think this description is still somewhat confusing. How about
changing that description into the following?
io_timeout is the request timeout in milliseconds. If a request does not
complete in this time then the block driver timeout handler is invoked.
That timeout handler can decide to retry the request, to fail it or to
start a device recovery strategy.
Bart.
next prev parent reply other threads:[~2018-12-06 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 14:17 [PATCH v3] block: add documentation for io_timeout Weiping Zhang
2018-12-05 14:40 ` Christoph Hellwig
2018-12-05 14:49 ` Weiping Zhang
2018-12-05 14:59 ` Weiping Zhang
2018-12-06 16:06 ` Bart Van Assche
2018-12-06 16:19 ` Christoph Hellwig
2018-12-06 16:19 ` Bart Van Assche [this message]
2018-12-26 1:51 ` Weiping Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544113174.185366.240.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=zhangweiping@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).