From: Bart Van Assche <bvanassche@acm.org>
To: Christoph Hellwig <hch@lst.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, Ming Lei <ming.lei@redhat.com>,
Hannes Reinecke <hare@suse.com>,
Paul Mackerras <paulus@ozlabs.org>,
Juergen Gross <jgross@suse.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/9] scsi: flip the default on use_clustering
Date: Thu, 06 Dec 2018 09:05:58 -0800 [thread overview]
Message-ID: <1544115958.185366.253.camel@acm.org> (raw)
In-Reply-To: <20181206155258.11465-2-hch@lst.de>
On Thu, 2018-12-06 at 07:52 -0800, Christoph Hellwig wrote:
> Most SCSI drivers want to enable "clustering", that is merging of
> segments so that they might span more than a single page. Remove the
> ENABLE_CLUSTERING define, and require drivers to explicitly set
> DISABLE_CLUSTERING to disable this feature. All drivers not setting
> use_clustering at all are switched to set DISABLE_CLUSTERING to keep
> the current behavior.
Was this patch produced manually or has it been generated with the help
of a script? In the latter case it would help if that script would be
included in the patch description.
Additionally, this patch would be much easier to review if it would be
split into two patches, one that adds .use_clustering = DISABLE_CLUSTERING
from SCSI templates that implicitly disable clustering and a second patch
that removes .use_clustering = ENABLE_CLUSTERING from all SCSI drivers.
Thanks,
Bart.
next prev parent reply other threads:[~2018-12-06 17:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 15:52 remove the "clustering" flag Christoph Hellwig
2018-12-06 15:52 ` [PATCH 1/9] scsi: flip the default on use_clustering Christoph Hellwig
2018-12-06 17:05 ` Bart Van Assche [this message]
2018-12-06 15:52 ` [PATCH 2/9] scsi: introduce a max_segment_size host_template parameters Christoph Hellwig
2018-12-06 17:15 ` Bart Van Assche
2018-12-11 2:02 ` Ming Lei
2018-12-11 14:05 ` Christoph Hellwig
2018-12-06 15:52 ` [PATCH 3/9] myrb: remove the DISABLE_CLUSTERING flag Christoph Hellwig
2018-12-06 15:52 ` [PATCH 4/9] myrs: " Christoph Hellwig
2018-12-06 15:52 ` [PATCH 5/9] xen-scsifront: remove DISABLE_CLUSTERING Christoph Hellwig
2018-12-06 15:52 ` [PATCH 6/9] mesh: " Christoph Hellwig
2018-12-06 22:07 ` Paul Mackerras
2018-12-06 15:52 ` [PATCH 7/9] mac53c94: " Christoph Hellwig
2018-12-06 22:07 ` Paul Mackerras
2018-12-06 15:52 ` [PATCH 8/9] scsi: remove the use_clustering flag Christoph Hellwig
2018-12-06 17:13 ` Bart Van Assche
2018-12-08 17:51 ` Christoph Hellwig
2018-12-06 15:52 ` [PATCH 9/9] block: remove the cluster flag Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544115958.185366.253.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jgross@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).