From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Cc: Mike Snitzer <snitzer@redhat.com>, Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH v3] blk-mq: punt failed direct issue to dispatch list
Date: Fri, 07 Dec 2018 08:41:19 -0800 [thread overview]
Message-ID: <1544200879.185366.314.camel@acm.org> (raw)
In-Reply-To: <7eaf8a39-3628-e153-79c9-0f115a4392d4@kernel.dk>
On Fri, 2018-12-07 at 09:35 -0700, Jens Axboe wrote:
> diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c
> index 29bfe8017a2d..9e5bda8800f8 100644
> --- a/block/blk-mq-sched.c
> +++ b/block/blk-mq-sched.c
> @@ -377,6 +377,16 @@ void blk_mq_sched_insert_request(struct request *rq, bool at_head,
>
> WARN_ON(e && (rq->tag != -1));
>
> + /*
> + * It's illegal to insert a request into the scheduler that has
> + * been through ->queue_rq(). Warn for that case, and use a bypass
> + * insert to be safe.
> + */
Shouldn't this refer to requests that have been prepared instead of requests
that have been through ->queue_rq()? I think this function is called for
requests that are requeued. Requeued requests have been through ->queue_rq()
but are unprepared before being requeued.
Thanks,
Bart.
next prev parent reply other threads:[~2018-12-07 16:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 5:17 [PATCH v3] blk-mq: punt failed direct issue to dispatch list Jens Axboe
2018-12-07 8:24 ` Ming Lei
2018-12-07 10:50 ` Ming Lei
2018-12-07 15:15 ` Mike Snitzer
2018-12-07 16:19 ` Bart Van Assche
2018-12-07 16:24 ` Jens Axboe
2018-12-07 16:35 ` Jens Axboe
2018-12-07 16:41 ` Bart Van Assche [this message]
2018-12-07 16:45 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544200879.185366.314.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).