From: Bart Van Assche <bvanassche@acm.org>
To: Evan Green <evgreen@chromium.org>, Jens Axboe <axboe@kernel.dk>
Cc: Gwendal Grignou <gwendal@chromium.org>,
Martin K Peterson <martin.peterson@oracle.com>,
Alexis Savery <asavery@chromium.org>,
Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 1/2] loop: Report EOPNOTSUPP properly
Date: Thu, 31 Jan 2019 15:31:19 -0800 [thread overview]
Message-ID: <1548977479.213038.20.camel@acm.org> (raw)
In-Reply-To: <20190131221328.85343-2-evgreen@chromium.org>
On Thu, 2019-01-31 at 14:13 -0800, Evan Green wrote:
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index cf5538942834..a1ba555e3b92 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -458,8 +458,13 @@ static void lo_complete_rq(struct request *rq)
>
> if (!cmd->use_aio || cmd->ret < 0 || cmd->ret == blk_rq_bytes(rq) ||
> req_op(rq) != REQ_OP_READ) {
> - if (cmd->ret < 0)
> - ret = BLK_STS_IOERR;
> + if (cmd->ret < 0) {
> + if (cmd->ret == -EOPNOTSUPP)
> + ret = BLK_STS_NOTSUPP;
> + else
> + ret = BLK_STS_IOERR;
> + }
Please do not nest if-conditions if that is not necessary. I think the
above code can be written more clearly as follows:
if (cmd->ret == -ENOTSUPP)
ret = BLK_STS_NOTSUPP;
else if (cmd->ret < 0)
ret = BLK_STS_IOERR;
Thanks,
Bart.
next prev parent reply other threads:[~2019-01-31 23:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 22:13 [RESEND PATCH 0/2] loop: Better discard for block devices Evan Green
2019-01-31 22:13 ` [RESEND PATCH 1/2] loop: Report EOPNOTSUPP properly Evan Green
2019-01-31 23:31 ` Bart Van Assche [this message]
2019-02-01 18:18 ` Evan Green
2019-01-31 22:13 ` [RESEND PATCH 2/2] loop: Better discard support for block devices Evan Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548977479.213038.20.camel@acm.org \
--to=bvanassche@acm.org \
--cc=asavery@chromium.org \
--cc=axboe@kernel.dk \
--cc=evgreen@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.peterson@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).