From: Bart Van Assche <bvanassche@acm.org>
To: Jianchao Wang <jianchao.w.wang@oracle.com>, axboe@kernel.dk
Cc: hch@lst.de, jthumshirn@suse.de, hare@suse.de,
josef@toxicpanda.com, sagi@grimberg.me, keith.busch@intel.com,
jsmart2021@gmail.com, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8]: blk-mq: use static_rqs to iterate busy tags
Date: Mon, 18 Mar 2019 10:28:05 -0700 [thread overview]
Message-ID: <1552930085.152266.36.camel@acm.org> (raw)
In-Reply-To: <1552640264-26101-1-git-send-email-jianchao.w.wang@oracle.com>
On Fri, 2019-03-15 at 16:57 +0800, Jianchao Wang wrote:
> [2] https://marc.info/?l=linux-block&m=154526189023236&w=2
Hi Jianchao,
That is a reference to the "BUG: KASAN: use-after-free in bt_iter" issue.
I think that issue can be fixed in another way than modifying all code that
iterates over tags, namely by adding an rcu_read_lock() / rcu_read_unlock()
pair in bt_for_each() and bt_tags_for_each() and by changing the calls in
blk_mq_free_rqs() and blk_free_flush_queue() that free the data structures
used by the tag iteration functions into kfree_rcu() or call_rcu() calls.
Thanks,
Bart.
next prev parent reply other threads:[~2019-03-18 17:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 8:57 [PATCH 0/8]: blk-mq: use static_rqs to iterate busy tags Jianchao Wang
2019-03-15 8:57 ` [PATCH 1/8] blk-mq: get rid of the synchronize_rcu in __blk_mq_update_nr_hw_queues Jianchao Wang
2019-03-17 6:14 ` Ming Lei
2019-03-15 8:57 ` [PATCH 2/8] blk-mq: change the method of iterating busy tags of a request_queue Jianchao Wang
2019-03-15 16:16 ` Keith Busch
2019-03-17 6:50 ` Ming Lei
2019-03-18 15:53 ` Keith Busch
2019-03-18 1:49 ` jianchao.wang
2019-03-20 18:52 ` Sagi Grimberg
2019-03-21 1:33 ` jianchao.wang
2019-03-15 8:57 ` [PATCH 3/8] blk-mq: use blk_mq_queue_tag_busy_iter in debugfs Jianchao Wang
2019-03-15 8:57 ` [PATCH 4/8] mtip32xx: use blk_mq_queue_tag_busy_iter Jianchao Wang
2019-03-15 8:57 ` [PATCH 5/8] nbd: " Jianchao Wang
2019-03-18 17:16 ` Bart Van Assche
2019-03-19 2:04 ` jianchao.wang
2019-03-15 8:57 ` [PATCH 6/8] skd: " Jianchao Wang
2019-03-18 17:20 ` Bart Van Assche
2019-03-19 1:54 ` jianchao.wang
2019-03-15 8:57 ` [PATCH 7/8] nvme: " Jianchao Wang
2019-03-15 16:33 ` James Smart
2019-03-15 16:39 ` James Smart
2019-03-15 16:49 ` Hannes Reinecke
2019-03-18 7:00 ` jianchao.wang
2019-03-15 8:57 ` [PATCH 8/8] blk-mq: remove blk_mq_tagset_busy_iter Jianchao Wang
2019-03-15 9:20 ` [PATCH 0/8]: blk-mq: use static_rqs to iterate busy tags Christoph Hellwig
2019-03-15 9:44 ` jianchao.wang
2019-03-15 16:19 ` Bart Van Assche
2019-03-18 2:47 ` jianchao.wang
2019-03-15 13:30 ` Josef Bacik
2019-03-18 17:28 ` Bart Van Assche [this message]
2019-03-19 1:25 ` jianchao.wang
2019-03-19 15:10 ` Bart Van Assche
2019-03-19 15:25 ` Keith Busch
2019-03-20 18:38 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552930085.152266.36.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jianchao.w.wang@oracle.com \
--cc=josef@toxicpanda.com \
--cc=jsmart2021@gmail.com \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).