From: Bart Van Assche <bvanassche@acm.org>
To: weiping zhang <zhangweiping@didichuxing.com>
Cc: Weiping Zhang <zhangweiping@didiglobal.com>,
axboe@kernel.dk, hch@infradead.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: don't show io_timeout if driver has no timeout handler
Date: Mon, 01 Apr 2019 15:40:15 -0700 [thread overview]
Message-ID: <1554158415.118779.126.camel@acm.org> (raw)
In-Reply-To: <20190331152824.GA29577@192.168.3.9>
On Sun, 2019-03-31 at 23:28 +0800, weiping zhang wrote:
> On Tue, Jan 08, 2019 at 04:57:40PM -0800, Bart Van Assche wrote:
> > > @@ -942,6 +961,14 @@ int blk_register_queue(struct gendisk *disk)
> > > goto unlock;
> > > }
> > >
> > > + ret = sysfs_create_group(&q->kobj, &queue_attr_group);
> > > + if (ret) {
> > > + kobject_del(&q->kobj);
> > > + blk_trace_remove_sysfs(dev);
> > > + kobject_put(&dev->kobj);
> > > + goto unlock;
> > > + }
> >
> > Are you sure the "goto unlock" is OK here? Shouldn't kobject_del() be called
> > to undo the kobject_add() call if sysfs_create_group() fails?
>
> Sorry, can you tell me why it's may be not safe, if goto unlock here,
> if failed to call sysfs_create_group, I think we should call
> kobject_del.
Can you address the other comments and repost your patch? I may have misread
your patch when I wrote the above comment.
Thanks,
Bart.
next prev parent reply other threads:[~2019-04-01 22:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 12:52 [PATCH] block: don't show io_timeout if driver has no timeout handler Weiping Zhang
2019-01-07 15:43 ` Jens Axboe
2019-01-07 16:04 ` Bart Van Assche
2019-01-07 16:06 ` Jens Axboe
2019-01-09 0:57 ` Bart Van Assche
2019-03-31 15:28 ` weiping zhang
2019-04-01 22:40 ` Bart Van Assche [this message]
2019-04-02 12:43 ` Weiping Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554158415.118779.126.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=zhangweiping@didichuxing.com \
--cc=zhangweiping@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).