From: Bart Van Assche <bvanassche@acm.org>
To: Ming Lei <ming.lei@redhat.com>,
"jianchao.wang" <jianchao.w.wang@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
James Smart <james.smart@broadcom.com>,
Bart Van Assche <bart.vanassche@wdc.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>
Subject: Re: [PATCH 0/5] blk-mq: allow to run queue if queue refcount is held
Date: Tue, 02 Apr 2019 11:11:08 -0700 [thread overview]
Message-ID: <1554228668.118779.166.camel@acm.org> (raw)
In-Reply-To: <20190402025505.GB26316@ming.t460p>
On Tue, 2019-04-02 at 10:55 +0800, Ming Lei wrote:
> Also, isn't it the typical practice to release kobject related resources in
> its release handler?
A typical approach is to call kobject_del() before starting to clean up a
resource and to defer the final kfree() call to the release handler. I think
that's how it works today in the block layer core. That is easy to see in the
blk_mq_hw_sysfs_release() implementation:
static void blk_mq_hw_sysfs_release(struct kobject *kobj)
{
struct blk_mq_hw_ctx *hctx = container_of(kobj, struct blk_mq_hw_ctx,
kobj);
free_cpumask_var(hctx->cpumask);
kfree(hctx->ctxs);
kfree(hctx);
}
Bart.
next prev parent reply other threads:[~2019-04-02 18:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 3:09 [PATCH 0/5] blk-mq: allow to run queue if queue refcount is held Ming Lei
2019-03-31 3:09 ` [PATCH 1/5] blk-mq: re-organize blk_mq_exit_hctx() into two parts Ming Lei
2019-04-01 1:40 ` Dongli Zhang
2019-04-01 2:06 ` Ming Lei
2019-03-31 3:09 ` [PATCH 2/5] blk-mq: re-organize blk_mq_exit_hw_queues() " Ming Lei
2019-03-31 3:09 ` [PATCH 3/5] blk-mq: free hw queues in queue's release handler Ming Lei
2019-03-31 3:09 ` [PATCH 4/5] block: don't drain in-progress dispatch in blk_cleanup_queue() Ming Lei
2019-04-01 1:50 ` Dongli Zhang
2019-04-01 2:08 ` Ming Lei
2019-03-31 3:09 ` [PATCH 5/5] SCSI: don't grab queue usage counter before run queue Ming Lei
2019-04-01 1:53 ` Dongli Zhang
2019-03-31 15:27 ` [PATCH 0/5] blk-mq: allow to run queue if queue refcount is held Bart Van Assche
2019-04-01 2:00 ` Ming Lei
2019-04-01 2:39 ` Bart Van Assche
2019-04-01 2:44 ` jianchao.wang
2019-04-02 18:07 ` Bart Van Assche
2019-04-01 2:52 ` Ming Lei
2019-04-01 3:25 ` jianchao.wang
2019-04-01 3:28 ` Ming Lei
2019-04-01 9:19 ` jianchao.wang
2019-04-01 10:03 ` Ming Lei
2019-04-02 2:02 ` jianchao.wang
2019-04-02 2:55 ` Ming Lei
2019-04-02 8:07 ` jianchao.wang
2019-04-02 11:05 ` Ming Lei
2019-04-02 17:53 ` Bart Van Assche
2019-04-03 3:20 ` Ming Lei
2019-04-03 8:29 ` Ming Lei
2019-04-03 8:43 ` Ming Lei
2019-04-02 18:11 ` Bart Van Assche [this message]
2019-04-03 3:24 ` Ming Lei
2019-04-01 5:05 ` Dongli Zhang
2019-04-01 5:16 ` Ming Lei
2019-04-01 5:30 ` Dongli Zhang
2019-04-01 7:15 ` Ming Lei
2019-04-02 2:10 ` Dongli Zhang
2019-04-02 2:20 ` Ming Lei
2019-04-01 3:27 ` Ming Lei
2019-04-01 3:32 ` jianchao.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554228668.118779.166.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).