linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Raul E Rangel <rrangel@chromium.org>, linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] block: Fix function name in comment
Date: Thu, 02 May 2019 13:33:45 -0700	[thread overview]
Message-ID: <1556829225.12970.10.camel@acm.org> (raw)
In-Reply-To: <20190502194811.200677-1-rrangel@chromium.org>

On Thu, 2019-05-02 at 13:48 -0600, Raul E Rangel wrote:
> The comment was out of date.
> 
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
> ---
> 
>  block/blk-mq.c | 2 +
>  1 file changed, 1 insertion(), 1 deletion(-)
> 
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 9516304a38ee..0e467ff440a2 100644
> --- a/block/blk-mq.c
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 9516304a38ee..0e467ff440a2 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -2062,7 +2062,7 @@ void blk_mq_free_rqs(struct blk_mq_tag_set *set, struct blk_mq_tags *tags,
>                 list_del_init(&page->lru);
>                 /*
>                  * Remove kmemleak object previously allocated in
> -                * blk_mq_init_rq_map().
> +                * blk_mq_alloc_rqs().
>                  */
>                 kmemleak_free(page_address(page));
>                 __free_pages(page, page->private);

Does the entire comment fit on a single 80 column line? In other words, can
the comment that is spread over four lines be reduced to a single line?

Thanks,

Bart.

  reply	other threads:[~2019-05-02 20:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-02 19:48 [PATCH] block: Fix function name in comment Raul E Rangel
2019-05-02 20:33 ` Bart Van Assche [this message]
2019-05-02 20:51   ` Raul Rangel
2019-05-02 20:56     ` Bart Van Assche
2019-05-02 20:58 ` Bart Van Assche
2019-05-02 21:54 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1556829225.12970.10.camel@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rrangel@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).