* [PATCH] block: Fix function name in comment
@ 2019-05-02 19:48 Raul E Rangel
2019-05-02 20:33 ` Bart Van Assche
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Raul E Rangel @ 2019-05-02 19:48 UTC (permalink / raw)
To: linux-block; +Cc: Raul E Rangel, linux-kernel, Jens Axboe
The comment was out of date.
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
---
block/blk-mq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 9516304a38ee..0e467ff440a2 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -2062,7 +2062,7 @@ void blk_mq_free_rqs(struct blk_mq_tag_set *set, struct blk_mq_tags *tags,
list_del_init(&page->lru);
/*
* Remove kmemleak object previously allocated in
- * blk_mq_init_rq_map().
+ * blk_mq_alloc_rqs().
*/
kmemleak_free(page_address(page));
__free_pages(page, page->private);
--
2.21.0.593.g511ec345e18-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] block: Fix function name in comment
2019-05-02 19:48 [PATCH] block: Fix function name in comment Raul E Rangel
@ 2019-05-02 20:33 ` Bart Van Assche
2019-05-02 20:51 ` Raul Rangel
2019-05-02 20:58 ` Bart Van Assche
2019-05-02 21:54 ` Jens Axboe
2 siblings, 1 reply; 6+ messages in thread
From: Bart Van Assche @ 2019-05-02 20:33 UTC (permalink / raw)
To: Raul E Rangel, linux-block; +Cc: linux-kernel, Jens Axboe
On Thu, 2019-05-02 at 13:48 -0600, Raul E Rangel wrote:
> The comment was out of date.
>
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
> ---
>
> block/blk-mq.c | 2 +
> 1 file changed, 1 insertion(), 1 deletion(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 9516304a38ee..0e467ff440a2 100644
> --- a/block/blk-mq.c
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 9516304a38ee..0e467ff440a2 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -2062,7 +2062,7 @@ void blk_mq_free_rqs(struct blk_mq_tag_set *set, struct blk_mq_tags *tags,
> list_del_init(&page->lru);
> /*
> * Remove kmemleak object previously allocated in
> - * blk_mq_init_rq_map().
> + * blk_mq_alloc_rqs().
> */
> kmemleak_free(page_address(page));
> __free_pages(page, page->private);
Does the entire comment fit on a single 80 column line? In other words, can
the comment that is spread over four lines be reduced to a single line?
Thanks,
Bart.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] block: Fix function name in comment
2019-05-02 20:33 ` Bart Van Assche
@ 2019-05-02 20:51 ` Raul Rangel
2019-05-02 20:56 ` Bart Van Assche
0 siblings, 1 reply; 6+ messages in thread
From: Raul Rangel @ 2019-05-02 20:51 UTC (permalink / raw)
To: Bart Van Assche; +Cc: linux-block, linux-kernel, Jens Axboe
On Thu, May 02, 2019 at 01:33:45PM -0700, Bart Van Assche wrote:
> On Thu, 2019-05-02 at 13:48 -0600, Raul E Rangel wrote:
> > The comment was out of date.
> >
> > Signed-off-by: Raul E Rangel <rrangel@chromium.org>
> > ---
> >
> > block/blk-mq.c | 2 +
> > 1 file changed, 1 insertion(), 1 deletion(-)
> >
> > diff --git a/block/blk-mq.c b/block/blk-mq.c
> > index 9516304a38ee..0e467ff440a2 100644
> > --- a/block/blk-mq.c
> > diff --git a/block/blk-mq.c b/block/blk-mq.c
> > index 9516304a38ee..0e467ff440a2 100644
> > --- a/block/blk-mq.c
> > +++ b/block/blk-mq.c
> > @@ -2062,7 +2062,7 @@ void blk_mq_free_rqs(struct blk_mq_tag_set *set, struct blk_mq_tags *tags,
> > list_del_init(&page->lru);
> > /*
> > * Remove kmemleak object previously allocated in
> > - * blk_mq_init_rq_map().
> > + * blk_mq_alloc_rqs().
> > */
> > kmemleak_free(page_address(page));
> > __free_pages(page, page->private);
>
> Does the entire comment fit on a single 80 column line? In other words, can
> the comment that is spread over four lines be reduced to a single line?
No, it would put it at 91 characters long.
Raul
>
> Thanks,
>
> Bart.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] block: Fix function name in comment
2019-05-02 20:51 ` Raul Rangel
@ 2019-05-02 20:56 ` Bart Van Assche
0 siblings, 0 replies; 6+ messages in thread
From: Bart Van Assche @ 2019-05-02 20:56 UTC (permalink / raw)
To: Raul Rangel; +Cc: linux-block, linux-kernel, Jens Axboe
On Thu, 2019-05-02 at 14:51 -0600, Raul Rangel wrote:
> On Thu, May 02, 2019 at 01:33:45PM -0700, Bart Van Assche wrote:
> > On Thu, 2019-05-02 at 13:48 -0600, Raul E Rangel wrote:
> > > The comment was out of date.
> > >
> > > Signed-off-by: Raul E Rangel <rrangel@chromium.org>
> > > ---
> > >
> > > block/blk-mq.c | 2 +
> > > 1 file changed, 1 insertion(), 1 deletion(-)
> > >
> > > diff --git a/block/blk-mq.c b/block/blk-mq.c
> > > index 9516304a38ee..0e467ff440a2 100644
> > > --- a/block/blk-mq.c
> > > diff --git a/block/blk-mq.c b/block/blk-mq.c
> > > index 9516304a38ee..0e467ff440a2 100644
> > > --- a/block/blk-mq.c
> > > +++ b/block/blk-mq.c
> > > @@ -2062,7 +2062,7 @@ void blk_mq_free_rqs(struct blk_mq_tag_set *set, struct blk_mq_tags *tags,
> > > list_del_init(&page->lru);
> > > /*
> > > * Remove kmemleak object previously allocated in
> > > - * blk_mq_init_rq_map().
> > > + * blk_mq_alloc_rqs().
> > > */
> > > kmemleak_free(page_address(page));
> > > __free_pages(page, page->private);
> >
> > Does the entire comment fit on a single 80 column line? In other words, can
> > the comment that is spread over four lines be reduced to a single line?
>
> No, it would put it at 91 characters long.
That's unfortunate ...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] block: Fix function name in comment
2019-05-02 19:48 [PATCH] block: Fix function name in comment Raul E Rangel
2019-05-02 20:33 ` Bart Van Assche
@ 2019-05-02 20:58 ` Bart Van Assche
2019-05-02 21:54 ` Jens Axboe
2 siblings, 0 replies; 6+ messages in thread
From: Bart Van Assche @ 2019-05-02 20:58 UTC (permalink / raw)
To: Raul E Rangel, linux-block; +Cc: linux-kernel, Jens Axboe
On Thu, 2019-05-02 at 13:48 -0600, Raul E Rangel wrote:
> The comment was out of date.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] block: Fix function name in comment
2019-05-02 19:48 [PATCH] block: Fix function name in comment Raul E Rangel
2019-05-02 20:33 ` Bart Van Assche
2019-05-02 20:58 ` Bart Van Assche
@ 2019-05-02 21:54 ` Jens Axboe
2 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2019-05-02 21:54 UTC (permalink / raw)
To: Raul E Rangel, linux-block; +Cc: linux-kernel
On 5/2/19 1:48 PM, Raul E Rangel wrote:
> The comment was out of date.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-02 21:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-02 19:48 [PATCH] block: Fix function name in comment Raul E Rangel
2019-05-02 20:33 ` Bart Van Assche
2019-05-02 20:51 ` Raul Rangel
2019-05-02 20:56 ` Bart Van Assche
2019-05-02 20:58 ` Bart Van Assche
2019-05-02 21:54 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).