* [PATCH] block: wbt: Remove unnecessary invoking of wbt_update_limits in wbt_init
@ 2020-11-30 2:20 chenlei0x
2020-11-30 18:10 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: chenlei0x @ 2020-11-30 2:20 UTC (permalink / raw)
To: chenlei0x, axboe, linux-block, linux-kernel; +Cc: Lei Chen
From: Lei Chen <lennychen@tencent.com>
It's unnecessary to call wbt_update_limits explicitly within wbt_init,
because it will be called in the following function wbt_queue_depth_changed.
Signed-off-by: Lei Chen <lennychen@tencent.com>
---
block/blk-wbt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/blk-wbt.c b/block/blk-wbt.c
index fd41008..0321ca8 100644
--- a/block/blk-wbt.c
+++ b/block/blk-wbt.c
@@ -835,7 +835,6 @@ int wbt_init(struct request_queue *q)
rwb->enable_state = WBT_STATE_ON_DEFAULT;
rwb->wc = 1;
rwb->rq_depth.default_depth = RWB_DEF_DEPTH;
- wbt_update_limits(rwb);
/*
* Assign rwb and add the stats callback.
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block: wbt: Remove unnecessary invoking of wbt_update_limits in wbt_init
2020-11-30 2:20 [PATCH] block: wbt: Remove unnecessary invoking of wbt_update_limits in wbt_init chenlei0x
@ 2020-11-30 18:10 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-11-30 18:10 UTC (permalink / raw)
To: chenlei0x, linux-block, linux-kernel; +Cc: Lei Chen
On 11/29/20 7:20 PM, chenlei0x@gmail.com wrote:
> From: Lei Chen <lennychen@tencent.com>
>
> It's unnecessary to call wbt_update_limits explicitly within wbt_init,
> because it will be called in the following function wbt_queue_depth_changed.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-30 18:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-30 2:20 [PATCH] block: wbt: Remove unnecessary invoking of wbt_update_limits in wbt_init chenlei0x
2020-11-30 18:10 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).