From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, Yi Zhang <yi.zhang@redhat.com>
Subject: Re: [PATCH] block: drain queue after disk is removed from sysfs
Date: Tue, 26 Oct 2021 08:44:43 -0600 [thread overview]
Message-ID: <163525948334.224837.7501575309877841006.b4-ty@kernel.dk> (raw)
In-Reply-To: <20211026101204.2897166-1-ming.lei@redhat.com>
On Tue, 26 Oct 2021 18:12:04 +0800, Ming Lei wrote:
> Before removing disk from sysfs, userspace still may change queue via
> sysfs, such as switching elevator or setting wbt latency, both may
> reinitialize wbt, then the warning in blk_free_queue_stats() will be
> triggered since rq_qos_exit() is moved to del_gendisk().
>
> Fixes the issue by moving draining queue & tearing down after disk is
> removed from sysfs, at that time no one can come into queue's
> store()/show().
>
> [...]
Applied, thanks!
[1/1] block: drain queue after disk is removed from sysfs
commit: d308ae0d299a6bb15be4efb91849582d19c23213
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2021-10-26 14:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 10:12 [PATCH] block: drain queue after disk is removed from sysfs Ming Lei
2021-10-26 14:44 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163525948334.224837.7501575309877841006.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox