From: Jens Axboe <axboe@kernel.dk>
To: Jan Kara <jack@suse.cz>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: llvm@lists.linux.dev, Nathan Chancellor <nathan@kernel.org>,
linux-kernel@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] block: drop needless assignment in set_task_ioprio()
Date: Thu, 23 Dec 2021 07:10:19 -0700 [thread overview]
Message-ID: <164026861975.771757.2667766405282712502.b4-ty@kernel.dk> (raw)
In-Reply-To: <20211223125300.20691-1-lukas.bulwahn@gmail.com>
On Thu, 23 Dec 2021 13:53:00 +0100, Lukas Bulwahn wrote:
> Commit 5fc11eebb4a9 ("block: open code create_task_io_context in
> set_task_ioprio") introduces a needless assignment
> 'ioc = task->io_context', as the local variable ioc is not further
> used before returning.
>
> Even after the further fix, commit a957b61254a7 ("block: fix error in
> handling dead task for ioprio setting"), the assignment still remains
> needless.
>
> [...]
Applied, thanks!
[1/1] block: drop needless assignment in set_task_ioprio()
commit: 669a064625fa3a06ddf8a4ac1f35b7436b99f133
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2021-12-23 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 12:53 [PATCH v2] block: drop needless assignment in set_task_ioprio() Lukas Bulwahn
2021-12-23 12:57 ` Christoph Hellwig
2021-12-23 14:10 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164026861975.771757.2667766405282712502.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=lukas.bulwahn@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox