From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECC85C433FE for ; Mon, 14 Mar 2022 20:24:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244971AbiCNUZK (ORCPT ); Mon, 14 Mar 2022 16:25:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241268AbiCNUZJ (ORCPT ); Mon, 14 Mar 2022 16:25:09 -0400 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21C08338BF for ; Mon, 14 Mar 2022 13:23:59 -0700 (PDT) Received: by mail-io1-xd31.google.com with SMTP id x4so19763672iop.7 for ; Mon, 14 Mar 2022 13:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=T1epUkuBEZR2LhEdTqhXHlnF09YRfThD+WUlWYZsbP0=; b=fWGutWI0+heOIc6s/q00lJpgol9Zvzto/tICQBOMfxpWn88QkI04LQNjbtcSoRtoNZ u6uWsaJjXbByOdfxzfe1qtbAIBQypO/oZyGNtMMSFPVTGcQNsKjgswRWumXleVk7Pncq zDDcwYAWM7ltxc+5zs6D+6nBX4VZsSLj4+ryaHBUi/GxNunfhRZ89zy01PhaWgklJF35 92Hnji94/RVDOTuH/pSUDVr0ffZd1iFZZBy0L/aOM6ItNK4uBsvfrN9Tx/t5364NyonN eoTNaNSEy7FL+7FkWLjjRXC5D3tJKbdVOO5TPbUG8V0ux358zUKMSK/N3ayhXJ/WcEYJ gm3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=T1epUkuBEZR2LhEdTqhXHlnF09YRfThD+WUlWYZsbP0=; b=GZswOUIK72YtC68JqEjDpCdS4fLOrAIYBJFsuFdfPN1T94qiSiX6mCJPVUKy1drD86 pElO9KT6MPpNjFNGkOFtfd05tKiohkzYuHmpul5W57fJH/7lvCz3rB43kCkOFak4r/0S BiZrxlxiwt251KC/DWcCyhoSW+821RbAE6NlyBTK/1THJWrmvf+Pj0ejYLaQbDZ4yS8d wODQHnjkVSeJrbcq9ppF/5bO+ReGHVgif8V62WwXkyVhgRFxvlxBewWvMuj9HW8bkFrh LAc+U3uEWEjWHAAz2tCb0Bos33CNk60cNHrXAqSIBISItYHrOym02fKFOHDE6It9Pleq Q79Q== X-Gm-Message-State: AOAM532n0lBKrYrN13s31Q/z2vZKOisc0nUNCj9znTW/uv/LfRRy2STi AHb59cOG3WJ5UaOkd91VZblUIQ== X-Google-Smtp-Source: ABdhPJzFeprnrbWSaeXT0Xqz0t75bLQpl1HbWK/xqoNcZCH+IS0MjT6fe3aSlh6501m3gcpRMBYtHQ== X-Received: by 2002:a02:1143:0:b0:308:eb2e:70ef with SMTP id 64-20020a021143000000b00308eb2e70efmr22039594jaf.248.1647289438486; Mon, 14 Mar 2022 13:23:58 -0700 (PDT) Received: from [127.0.1.1] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id u15-20020a056e021a4f00b002c665afb993sm10033922ilv.11.2022.03.14.13.23.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Mar 2022 13:23:58 -0700 (PDT) From: Jens Axboe To: Tejun Heo Cc: Ming Lei , Yu Kuai , kernel-team@fb.com, Christopher Obbard , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Saravanan D In-Reply-To: References: Subject: Re: [PATCH block-5.17] fix rq-qos breakage from skipping rq_qos_done_bio() Message-Id: <164728943786.144850.10059816217572335500.b4-ty@kernel.dk> Date: Mon, 14 Mar 2022 14:23:57 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sun, 13 Mar 2022 21:15:02 -1000, Tejun Heo wrote: > a647a524a467 ("block: don't call rq_qos_ops->done_bio if the bio isn't > tracked") made bio_endio() skip rq_qos_done_bio() if BIO_TRACKED is not set. > While this fixed a potential oops, it also broke blk-iocost by skipping the > done_bio callback for merged bios. > > Before, whether a bio goes through rq_qos_throttle() or rq_qos_merge(), > rq_qos_done_bio() would be called on the bio on completion with BIO_TRACKED > distinguishing the former from the latter. rq_qos_done_bio() is not called > for bios which wenth through rq_qos_merge(). This royally confuses > blk-iocost as the merged bios never finish and are considered perpetually > in-flight. > > [...] Applied, thanks! [1/1] fix rq-qos breakage from skipping rq_qos_done_bio() (no commit info) Best regards, -- Jens Axboe