From: Jens Axboe <axboe@kernel.dk>
To: Pankaj Raghav <p.raghav@samsung.com>, hch@lst.de
Cc: damien.lemoal@opensource.wdc.com, gost.dev@samsung.com,
linux-block@vger.kernel.org
Subject: Re: [PATCH] block: add rationale for not using blk_mq_plug() when applicable
Date: Thu, 29 Sep 2022 09:03:02 -0600 [thread overview]
Message-ID: <166446378255.69599.14942031119369908314.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220929144141.140077-1-p.raghav@samsung.com>
On Thu, 29 Sep 2022 16:41:41 +0200, Pankaj Raghav wrote:
> There are two places in the block layer at the moment where
> blk_mq_plug() helper could be used instead of directly accessing the
> plug from struct current. In both these cases, directly accessing the plug
> should not have any consequences for zoned devices.
>
> Make the intent explicit by adding comments instead of introducing unwanted
> checks with blk_mq_plug() helper.[1]
>
> [...]
Applied, thanks!
[1/1] block: add rationale for not using blk_mq_plug() when applicable
commit: 110fdb4486d3a5e67d55bc6866d6426e6d49ccfc
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-09-29 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220929144143eucas1p2a68d7cb3f5e347954e3a5a5e335cf620@eucas1p2.samsung.com>
2022-09-29 14:41 ` [PATCH] block: add rationale for not using blk_mq_plug() when applicable Pankaj Raghav
2022-09-29 15:02 ` Jens Axboe
2022-09-29 15:03 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166446378255.69599.14942031119369908314.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox