From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
linux-scsi@vger.kernel.org, Keith Busch <kbusch@kernel.org>,
linux-block@vger.kernel.org, Sven Peter <sven@svenpeter.dev>,
Hector Martin <marcan@marcan.st>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-nvme@lists.infradead.org
Subject: Re: don't drop the queue reference in blk_mq_destroy_queue
Date: Tue, 25 Oct 2022 08:26:18 -0600 [thread overview]
Message-ID: <166670797886.12575.5830280614420890136.b4-ty@kernel.dk> (raw)
In-Reply-To: <20221018135720.670094-1-hch@lst.de>
On Tue, 18 Oct 2022 15:57:16 +0200, Christoph Hellwig wrote:
> currently blk_mq_destroy_queue not only shuts down the queue, but also
> drops a queue references, which leads to the NVMe PCIe/Apple drivers and
> scsi grabbing an extra references. Fix this to help with unifying more
> code between the various NVMe drivers (and to make the code a little saner
> even on it's own).
>
> Diffstat:
> block/blk-mq.c | 4 +---
> block/bsg-lib.c | 2 ++
> drivers/nvme/host/apple.c | 8 --------
> drivers/nvme/host/core.c | 10 ++++++++--
> drivers/nvme/host/pci.c | 5 -----
> drivers/scsi/scsi_scan.c | 1 -
> drivers/ufs/core/ufshcd.c | 2 ++
> 7 files changed, 13 insertions(+), 19 deletions(-)
>
> [...]
Applied, thanks!
[1/4] blk-mq: move the call to blk_put_queue out of blk_mq_destroy_queue
commit: 2b3f056f72e56fa07df69b4705e0b46a6c08e77c
[2/4] scsi: remove an extra queue reference
commit: dc917c361422388f0d39d3f0dc2bc5a188c01156
[3/4] nvme-pci: remove an extra queue reference
commit: 7dcebef90d35de13a326f765dd787538880566f9
[4/4] nvme-apple: remove an extra queue reference
commit: 941f7298c70c7668416e7845fa76eb72c07d966b
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-10-25 14:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 13:57 don't drop the queue reference in blk_mq_destroy_queue Christoph Hellwig
2022-10-18 13:57 ` [PATCH 1/4] blk-mq: move the call to blk_put_queue out of blk_mq_destroy_queue Christoph Hellwig
2022-10-18 20:44 ` Chaitanya Kulkarni
2022-10-19 8:19 ` Sagi Grimberg
2022-10-25 14:23 ` Jens Axboe
2022-10-25 14:25 ` Jens Axboe
2022-10-18 13:57 ` [PATCH 2/4] scsi: remove an extra queue reference Christoph Hellwig
2022-10-18 20:44 ` Chaitanya Kulkarni
2022-10-19 1:16 ` Ming Lei
2022-10-19 1:23 ` Ming Lei
2022-10-19 8:19 ` Sagi Grimberg
2022-10-18 13:57 ` [PATCH 3/4] nvme-pci: " Christoph Hellwig
2022-10-18 20:44 ` Chaitanya Kulkarni
2022-10-19 8:19 ` Sagi Grimberg
2022-10-18 13:57 ` [PATCH 4/4] nvme-apple: " Christoph Hellwig
2022-10-18 17:51 ` Sven Peter
2022-10-18 20:45 ` Chaitanya Kulkarni
2022-10-19 8:19 ` Sagi Grimberg
2022-10-18 15:16 ` don't drop the queue reference in blk_mq_destroy_queue Keith Busch
2022-10-25 14:26 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166670797886.12575.5830280614420890136.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox