From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
Bart Van Assche <bvanassche@acm.org>,
linux-block@vger.kernel.org,
Stefan Hajnoczi <stefanha@redhat.com>,
Keith Busch <kbusch@kernel.org>,
David Jeffery <djeffery@redhat.com>
Subject: Re: [PATCH V3 1/1] blk-mq: avoid double ->queue_rq() because of early timeout
Date: Mon, 31 Oct 2022 07:25:00 -0600 [thread overview]
Message-ID: <166722270044.66567.13274204671032495059.b4-ty@kernel.dk> (raw)
In-Reply-To: <20221026051957.358818-1-ming.lei@redhat.com>
On Wed, 26 Oct 2022 13:19:57 +0800, Ming Lei wrote:
> From: David Jeffery <djeffery@redhat.com>
>
> David Jeffery found one double ->queue_rq() issue, so far it can
> be triggered in VM use case because of long vmexit latency or preempt
> latency of vCPU pthread or long page fault in vCPU pthread, then block
> IO req could be timed out before queuing the request to hardware but after
> calling blk_mq_start_request() during ->queue_rq(), then timeout handler
> may handle it by requeue, then double ->queue_rq() is caused, and kernel
> panic.
>
> [...]
Applied, thanks!
[1/1] blk-mq: avoid double ->queue_rq() because of early timeout
commit: 82c229476b8f6afd7e09bc4dc77d89dc19ff7688
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-10-31 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 5:19 [PATCH V3 1/1] blk-mq: avoid double ->queue_rq() because of early timeout Ming Lei
2022-10-28 21:38 ` Bart Van Assche
2022-10-31 0:34 ` Ming Lei
2022-10-31 13:25 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166722270044.66567.13274204671032495059.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=djeffery@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox