From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: ZiyangZhang <ZiyangZhang@linux.alibaba.com>,
Andreas Hindborg <andreas.hindborg@wdc.com>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
linux-block@vger.kernel.org
Subject: Re: [PATCH] ublk_drv: don't forward io commands in reserve order
Date: Wed, 23 Nov 2022 20:37:20 -0700 [thread overview]
Message-ID: <166926104058.22149.9267289540283878085.b4-ty@kernel.dk> (raw)
In-Reply-To: <20221121155645.396272-1-ming.lei@redhat.com>
On Mon, 21 Nov 2022 23:56:45 +0800, Ming Lei wrote:
> Either ublk_can_use_task_work() is true or not, io commands are
> forwarded to ublk server in reverse order, since llist_add() is
> always to add one element to the head of the list.
>
> Even though block layer doesn't guarantee request dispatch order,
> requests should be sent to hardware in the sequence order generated
> from io scheduler, which usually considers the request's LBA, and
> order is often important for HDD.
>
> [...]
Applied, thanks!
[1/1] ublk_drv: don't forward io commands in reserve order
commit: 7d4a93176e0142ce16d23c849a47d5b00b856296
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-11-24 3:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 15:56 [PATCH] ublk_drv: don't forward io commands in reserve order Ming Lei
2022-11-22 6:05 ` Ziyang Zhang
2022-11-22 8:00 ` Damien Le Moal
2022-11-24 2:00 ` Ming Lei
2022-11-24 3:37 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166926104058.22149.9267289540283878085.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=ZiyangZhang@linux.alibaba.com \
--cc=andreas.hindborg@wdc.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox