From: Jens Axboe <axboe@kernel.dk>
To: haris.iqbal@ionos.com, jinpu.wang@ionos.com,
christophe.jaillet@wanadoo.fr,
Guoqing Jiang <guoqing.jiang@linux.dev>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH V2] block/rnbd-clt: fix wrong max ID in ida_alloc_max
Date: Tue, 17 Jan 2023 08:33:48 -0700 [thread overview]
Message-ID: <167396962861.7227.6056453469138933870.b4-ty@kernel.dk> (raw)
In-Reply-To: <20221230010926.32243-1-guoqing.jiang@linux.dev>
On Fri, 30 Dec 2022 09:09:26 +0800, Guoqing Jiang wrote:
> We need to pass 'end - 1' to ida_alloc_max after switch from
> ida_simple_get to ida_alloc_max.
>
> Otherwise smatch warns.
>
> drivers/block/rnbd/rnbd-clt.c:1460 init_dev() error: Calling ida_alloc_max() with a 'max' argument which is a power of 2. -1 missing?
>
> [...]
Applied, thanks!
[1/1] block/rnbd-clt: fix wrong max ID in ida_alloc_max
commit: 9d6033e350694a67885605674244d43c9559dc36
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-01-17 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 1:09 [PATCH V2] block/rnbd-clt: fix wrong max ID in ida_alloc_max Guoqing Jiang
2023-01-02 11:46 ` Jinpu Wang
2023-01-17 13:30 ` Guoqing Jiang
2023-01-17 15:33 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167396962861.7227.6056453469138933870.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=christophe.jaillet@wanadoo.fr \
--cc=guoqing.jiang@linux.dev \
--cc=haris.iqbal@ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox