From: Jens Axboe <axboe@kernel.dk>
To: tj@kernel.org, chengming.zhou@linux.dev
Cc: josef@toxicpanda.com, osandov@fb.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org,
Chengming Zhou <zhouchengming@bytedance.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] blk-stat: fix QUEUE_FLAG_STATS clear
Date: Thu, 13 Apr 2023 06:49:42 -0600 [thread overview]
Message-ID: <168139018203.8989.17731261770336366712.b4-ty@kernel.dk> (raw)
In-Reply-To: <20230413062805.2081970-1-chengming.zhou@linux.dev>
On Thu, 13 Apr 2023 14:28:04 +0800, chengming.zhou@linux.dev wrote:
> We need to set QUEUE_FLAG_STATS for two cases:
> 1. blk_stat_enable_accounting()
> 2. blk_stat_add_callback()
>
> So we should clear it only when ((q->stats->accounting == 0) &&
> list_empty(&q->stats->callbacks)).
>
> [...]
Applied, thanks!
[1/2] blk-stat: fix QUEUE_FLAG_STATS clear
commit: 20de765f6d9da0c47b756429c60b41063b990a10
[2/2] blk-throttle: only enable blk-stat when BLK_DEV_THROTTLING_LOW
commit: 8e15dfbd9ae21e518979e3823e335073e725f445
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-04-13 12:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 6:28 [PATCH v2 1/2] blk-stat: fix QUEUE_FLAG_STATS clear chengming.zhou
2023-04-13 6:28 ` [PATCH v2 2/2] blk-throttle: only enable blk-stat when BLK_DEV_THROTTLING_LOW chengming.zhou
2023-04-13 12:49 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168139018203.8989.17731261770336366712.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=chengming.zhou@linux.dev \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@fb.com \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox