From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, stable@vger.kernel.org,
Jay Shin <jaeshin@redhat.com>, Tejun Heo <tj@kernel.org>,
Waiman Long <longman@redhat.com>,
mkoutny@suse.com, Yosry Ahmed <yosryahmed@google.com>
Subject: Re: [PATCH V4] blk-cgroup: Flush stats before releasing blkcg_gq
Date: Sun, 11 Jun 2023 19:49:43 -0600 [thread overview]
Message-ID: <168653458323.828509.645185217328655352.b4-ty@kernel.dk> (raw)
In-Reply-To: <20230609234249.1412858-1-ming.lei@redhat.com>
On Sat, 10 Jun 2023 07:42:49 +0800, Ming Lei wrote:
> As noted by Michal, the blkg_iostat_set's in the lockless list hold
> reference to blkg's to protect against their removal. Those blkg's
> hold reference to blkcg. When a cgroup is being destroyed,
> cgroup_rstat_flush() is only called at css_release_work_fn() which
> is called when the blkcg reference count reaches 0. This circular
> dependency will prevent blkcg and some blkgs from being freed after
> they are made offline.
>
> [...]
Applied, thanks!
[1/1] blk-cgroup: Flush stats before releasing blkcg_gq
commit: 20cb1c2fb7568a6054c55defe044311397e01ddb
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-06-12 1:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 23:42 [PATCH V4] blk-cgroup: Flush stats before releasing blkcg_gq Ming Lei
2023-06-12 1:36 ` Ming Lei
2023-06-12 1:49 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168653458323.828509.645185217328655352.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=jaeshin@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=longman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=mkoutny@suse.com \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox