From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org,
Andreas Hindborg <a.hindborg@samsung.com>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] ublk: fix 'warn: variable dereferenced before check 'req'' from Smatch
Date: Fri, 11 Aug 2023 08:13:34 -0600 [thread overview]
Message-ID: <169176321465.160916.11466301531789958956.b4-ty@kernel.dk> (raw)
In-Reply-To: <20230811135216.420404-1-ming.lei@redhat.com>
On Fri, 11 Aug 2023 21:52:16 +0800, Ming Lei wrote:
> The added check of 'req_op(req) == REQ_OP_ZONE_APPEND' should have been
> done after the request is confirmed as valid.
>
> Actually here, the request should always been true, so add one
> WARN_ON_ONCE(!req), meantime move the zone_append check after
> checking the request.
>
> [...]
Applied, thanks!
[1/1] ublk: fix 'warn: variable dereferenced before check 'req'' from Smatch
commit: e24721e441a7c640e4e7b2b63c23c06d9a750880
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2023-08-11 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 13:52 [PATCH] ublk: fix 'warn: variable dereferenced before check 'req'' from Smatch Ming Lei
2023-08-11 14:13 ` Jens Axboe [this message]
2023-08-11 14:44 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169176321465.160916.11466301531789958956.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=a.hindborg@samsung.com \
--cc=dan.carpenter@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox