From: Bart Van Assche <bvanassche@acm.org>
To: John Garry <john.g.garry@oracle.com>,
axboe@kernel.dk, paolo.valente@unimore.it
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
jiapeng.chong@linux.alibaba.com, hch@lst.de,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH 1/3] bdev: make blockdev_mnt static
Date: Fri, 14 Jun 2024 09:35:58 -0700 [thread overview]
Message-ID: <16e6501c-c8ae-4f18-9fef-fa9ab32d069d@acm.org> (raw)
In-Reply-To: <20240614090345.655716-2-john.g.garry@oracle.com>
On 6/14/24 2:03 AM, John Garry wrote:
> The blockdev_mnt are not used outside the file bdev.c, so the modification
> is defined as static.
If this patch would be reposted, please rewrite the above description such that
it becomes comprehensible.
> jpg: Remove closes bugzilla link
The above text should be surrounded with square brackets.
Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2024-06-14 16:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 9:03 [PATCH 0/3] Some block sparse fixes John Garry
2024-06-14 9:03 ` [PATCH 1/3] bdev: make blockdev_mnt static John Garry
2024-06-14 16:35 ` Bart Van Assche [this message]
2024-06-14 9:03 ` [PATCH 2/3] block: Drop locking annotation for limits_lock John Garry
2024-06-14 16:36 ` Bart Van Assche
2024-06-14 16:47 ` Christoph Hellwig
2024-06-14 9:03 ` [PATCH 3/3] block: BFQ: Refactor bfq_exit_icq() to silence sparse warning John Garry
2024-06-14 16:37 ` Bart Van Assche
2024-06-16 21:30 ` [PATCH 0/3] Some block sparse fixes Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16e6501c-c8ae-4f18-9fef-fa9ab32d069d@acm.org \
--to=bvanassche@acm.org \
--cc=abaci@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@unimore.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).