From: Michael Lyle <mlyle@lyle.org>
To: Coly Li <colyli@suse.de>, Jens Axboe <axboe@kernel.dk>
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] bcache: check all uuid elements when start flash only volumes
Date: Mon, 26 Feb 2018 19:54:11 -0800 [thread overview]
Message-ID: <16efbb53-4ecd-8a90-dbad-90027e155244@lyle.org> (raw)
In-Reply-To: <d041972d-8ba4-c4c7-2b91-b342174463ec@suse.de>
Reviewed-by: Michael Lyle <mlyle@lyle.org>
I have this and the other fix in the queue for testing tomorrow and will
pass along a changeset to Jens if all looks good. Thanks!
Mike
On 02/26/2018 08:15 AM, Coly Li wrote:
> On 27/02/2018 12:10 AM, Coly Li wrote:
>> Commit 2831231d4c3f ("bcache: reduce cache_set devices iteration by
>> devices_max_used") adds c->devices_max_used to reduce iteration of
>> c->uuids elements, this value is updated in bcache_device_attach().
>>
>> But for flash only volume, when calling flash_devs_run(), the function
>> bcache_device_attach() is not called yet and c->devices_max_used is not
>> updated. The unexpected result is, the flash only volume won't be run
>> by flash_devs_run().
>>
>> This patch fixes the issue by iterate all c->uuids elements in
>> flash_devs_run(). c->devices_max_used will be updated properly when
>> bcache_device_attach() gets called.
>>
>> Fixes: 2831231d4c3f ("bcache: reduce cache_set devices iteration by devices_max_used")
>> Reported-by: Tang Junhui <tang.junhui@zte.com.cn>
>> Signed-off-by: Coly Li <colyli@suse.de>
>> Cc: Michael Lyle <mlyle@lyle.org>
>> ---
>> drivers/md/bcache/super.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
>> index 312895788036..4d1d8dfb2d2a 100644
>> --- a/drivers/md/bcache/super.c
>> +++ b/drivers/md/bcache/super.c
>> @@ -1274,7 +1274,7 @@ static int flash_devs_run(struct cache_set *c)
>> struct uuid_entry *u;
>>
>> for (u = c->uuids;
>> - u < c->uuids + c->devices_max_used && !ret;
>> + u < c->uuids + c->nr_uuids && !ret;
>> u++)
>> if (UUID_FLASH_ONLY(u))
>> ret = flash_dev_run(c, u);
>>
>
> Hi Jens and Michael,
>
> Could you please have a look and pick this fix into 4.16 ? Commit
> 2831231d4c3f ("bcache: reduce cache_set devices iteration by
> devices_max_used") is just merged in 4.16-rc1, so I don't CC stable for
> this fix.
>
> And I still need a peer code reviewer on this patch, any Reviewed-by is
> welcome.
>
> Thanks to Junhui Tang for reporting this issue today.
>
> Coly Li
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2018-02-27 3:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 16:10 [PATCH] bcache: check all uuid elements when start flash only volumes Coly Li
2018-02-26 16:15 ` Coly Li
2018-02-27 3:54 ` Michael Lyle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16efbb53-4ecd-8a90-dbad-90027e155244@lyle.org \
--to=mlyle@lyle.org \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox