Linux block layer
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: penguin-kernel@i-love.sakura.ne.jp, linan666@huaweicloud.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	 yukuai3@huawei.com, yi.zhang@huawei.com, houtao1@huawei.com,
	 yangerkun@huawei.com
Subject: Re: [PATCH] block: add check of 'minors' and 'first_minor' in device_add_disk()
Date: Tue, 19 Dec 2023 08:23:29 -0700	[thread overview]
Message-ID: <170299940902.460104.1563250346911093809.b4-ty@kernel.dk> (raw)
In-Reply-To: <20231219075942.840255-1-linan666@huaweicloud.com>


On Tue, 19 Dec 2023 15:59:42 +0800, linan666@huaweicloud.com wrote:
> 'first_minor' represents the starting minor number of disks, and
> 'minors' represents the number of partitions in the device. Neither
> of them can be greater than MINORMASK + 1.
> 
> Commit e338924bd05d ("block: check minor range in device_add_disk()")
> only added the check of 'first_minor + minors'. However, their sum might
> be less than MINORMASK but their values are wrong. Complete the checks now.
> 
> [...]

Applied, thanks!

[1/1] block: add check of 'minors' and 'first_minor' in device_add_disk()
      commit: 4c434392c4777881d01beada6701eff8c76b43fe

Best regards,
-- 
Jens Axboe




      parent reply	other threads:[~2023-12-19 15:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19  7:59 [PATCH] block: add check of 'minors' and 'first_minor' in device_add_disk() linan666
2023-12-19 12:11 ` Christoph Hellwig
2023-12-19 15:23 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170299940902.460104.1563250346911093809.b4-ty@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=houtao1@huawei.com \
    --cc=linan666@huaweicloud.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox