From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
stable@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>,
Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
Zhiguo Niu <Zhiguo.Niu@unisoc.com>
Subject: Re: [PATCH] Revert "block/mq-deadline: use correct way to throttling write requests"
Date: Wed, 13 Mar 2024 15:56:25 -0600 [thread overview]
Message-ID: <171036698538.360413.6777553266929994961.b4-ty@kernel.dk> (raw)
In-Reply-To: <20240313214218.1736147-1-bvanassche@acm.org>
On Wed, 13 Mar 2024 14:42:18 -0700, Bart Van Assche wrote:
> The code "max(1U, 3 * (1U << shift) / 4)" comes from the Kyber I/O
> scheduler. The Kyber I/O scheduler maintains one internal queue per hwq
> and hence derives its async_depth from the number of hwq tags. Using
> this approach for the mq-deadline scheduler is wrong since the
> mq-deadline scheduler maintains one internal queue for all hwqs
> combined. Hence this revert.
>
> [...]
Applied, thanks!
[1/1] Revert "block/mq-deadline: use correct way to throttling write requests"
commit: 256aab46e31683d76d45ccbedc287b4d3f3e322b
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2024-03-13 21:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 21:42 [PATCH] Revert "block/mq-deadline: use correct way to throttling write requests" Bart Van Assche
2024-03-13 21:56 ` Jens Axboe [this message]
2024-03-14 1:03 ` 答复: " 牛志国 (Zhiguo Niu)
2024-03-14 17:08 ` Bart Van Assche
2024-03-14 19:31 ` Jens Axboe
2024-03-14 7:58 ` Harshit Mogalapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171036698538.360413.6777553266929994961.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=Zhiguo.Niu@unisoc.com \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox