From: Jens Axboe <axboe@kernel.dk>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-block <linux-block@vger.kernel.org>,
linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
fstests <fstests@vger.kernel.org>,
xfs <linux-xfs@vger.kernel.org>,
John Garry <john.g.garry@oracle.com>
Subject: Re: [PATCH] block: fix detection of unsupported WRITE SAME in blkdev_issue_write_zeroes
Date: Wed, 28 Aug 2024 08:51:21 -0600 [thread overview]
Message-ID: <172485668128.410120.18023172929961192707.b4-ty@kernel.dk> (raw)
In-Reply-To: <20240827175340.GB1977952@frogsfrogsfrogs>
On Tue, 27 Aug 2024 10:53:40 -0700, Darrick J. Wong wrote:
> On error, blkdev_issue_write_zeroes used to recheck the block device's
> WRITE SAME queue limits after submitting WRITE SAME bios. As stated in
> the comment, the purpose of this was to collapse all IO errors to
> EOPNOTSUPP if the effect of issuing bios was that WRITE SAME got turned
> off in the queue limits. Therefore, it does not make sense to reuse the
> zeroes limit that was read earlier in the function because we only care
> about the queue limit *now*, not what it was at the start of the
> function.
>
> [...]
Applied, thanks!
[1/1] block: fix detection of unsupported WRITE SAME in blkdev_issue_write_zeroes
(no commit info)
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2024-08-28 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 17:53 [PATCH] block: fix detection of unsupported WRITE SAME in blkdev_issue_write_zeroes Darrick J. Wong
2024-08-28 4:25 ` Christoph Hellwig
2024-08-28 8:06 ` John Garry
2024-08-28 14:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172485668128.410120.18023172929961192707.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox