From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>
Cc: Yi Sun <yi.sun@unisoc.com>, "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
virtualization@lists.linux.dev,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] virtio-blk: don't keep queue frozen during system suspend
Date: Thu, 05 Dec 2024 10:00:31 -0700 [thread overview]
Message-ID: <173341803146.638625.9371515835290273948.b4-ty@kernel.dk> (raw)
In-Reply-To: <20241112125821.1475793-1-ming.lei@redhat.com>
On Tue, 12 Nov 2024 20:58:21 +0800, Ming Lei wrote:
> Commit 4ce6e2db00de ("virtio-blk: Ensure no requests in virtqueues before
> deleting vqs.") replaces queue quiesce with queue freeze in virtio-blk's
> PM callbacks. And the motivation is to drain inflight IOs before suspending.
>
> block layer's queue freeze looks very handy, but it is also easy to cause
> deadlock, such as, any attempt to call into bio_queue_enter() may run into
> deadlock if the queue is frozen in current context. There are all kinds
> of ->suspend() called in suspend context, so keeping queue frozen in the
> whole suspend context isn't one good idea. And Marek reported lockdep
> warning[1] caused by virtio-blk's freeze queue in virtblk_freeze().
>
> [...]
Applied, thanks!
[1/1] virtio-blk: don't keep queue frozen during system suspend
commit: 7678abee0867e6b7fb89aa40f6e9f575f755fb37
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2024-12-05 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 12:58 [PATCH] virtio-blk: don't keep queue frozen during system suspend Ming Lei
2024-12-04 21:31 ` Stefan Hajnoczi
2024-12-05 17:00 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173341803146.638625.9371515835290273948.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=jasowang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=ming.lei@redhat.com \
--cc=mst@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=yi.sun@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox