From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org, Nilay Shroff <nilay@linux.ibm.com>
Cc: kjain@linux.ibm.com, hch@lst.de, ritesh.list@gmail.com,
ming.lei@redhat.com, gjoyce@linux.ibm.com
Subject: Re: [PATCHv2] block: Fix potential deadlock while freezing queue and acquiring sysfs_lock
Date: Fri, 13 Dec 2024 10:52:05 -0700 [thread overview]
Message-ID: <173411232591.124733.11260571979796173193.b4-ty@kernel.dk> (raw)
In-Reply-To: <20241210144222.1066229-1-nilay@linux.ibm.com>
On Tue, 10 Dec 2024 20:11:43 +0530, Nilay Shroff wrote:
> For storing a value to a queue attribute, the queue_attr_store function
> first freezes the queue (->q_usage_counter(io)) and then acquire
> ->sysfs_lock. This seems not correct as the usual ordering should be to
> acquire ->sysfs_lock before freezing the queue. This incorrect ordering
> causes the following lockdep splat which we are able to reproduce always
> simply by accessing /sys/kernel/debug file using ls command:
>
> [...]
Applied, thanks!
[1/1] block: Fix potential deadlock while freezing queue and acquiring sysfs_lock
commit: be26ba96421ab0a8fa2055ccf7db7832a13c44d2
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2024-12-13 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 14:41 [PATCHv2] block: Fix potential deadlock while freezing queue and acquiring sysfs_lock Nilay Shroff
2024-12-11 12:00 ` Ming Lei
2024-12-11 12:32 ` Nilay Shroff
2024-12-11 12:49 ` Ming Lei
2024-12-13 17:52 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173411232591.124733.11260571979796173193.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=gjoyce@linux.ibm.com \
--cc=hch@lst.de \
--cc=kjain@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nilay@linux.ibm.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox