From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AB9A17C224 for ; Thu, 6 Mar 2025 15:05:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741273513; cv=none; b=A2/HLT/pkLs2UmyqrmNEz4xV/IaSd+QEoIqyu1BXwJE1hn27+rppowKk9qbBAPpOslF6/fZplqDjt1BJxh2L/YmqcRIOhDvMSvQ/50XBpPxU25up7OpZwqSP/x8A71nk2jVm3wEk87sickiVOwLSydK6oBVkxg6mWI36tybvXss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741273513; c=relaxed/simple; bh=TK7VGJ9wAuiaUqk6rSlvDmS9VC/uE/WDIOEUN3K8tI0=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=dz6aTuKf1CNpdRezYf7VIh0AiD8e7n08MnckY3CH3YGajzv37sRUxrogCk1FzCk8nnyQl8Iw1x2nDevUWmsLw5Urdy4JlKEDuuIxR0LHIuN8GhCWvCvLEk19q4BP4nt8fdXoGxKCC7wLfW+MYT7hP9Hny3mUGrI4+pT+qDWXfyo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=NvgHTTU2; arc=none smtp.client-ip=209.85.166.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="NvgHTTU2" Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-85ae65ba2f1so19974839f.3 for ; Thu, 06 Mar 2025 07:05:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1741273511; x=1741878311; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0mxhfe662mFKXoNMPrYea9QmFeK+eqDDltOasYkoZcA=; b=NvgHTTU2TllHBEQWB2pvDA/nfQKDVLudgEdr0YEBWbOa1T6vXQ7rR1iOv3mQfPrfJH B1aqThg3vk/KJp9QpV7acjALcfdhJ06C3hnXRMIlf5d6BueokYIQT4O0ce2hyMZm4UPi ua+dMMX8rMpepOyzjj5ccMSLPVcw7ZJdAHzpPXRZGzDUg3WLdJLQtYWuQZ2YQRqYfxs0 g5vc2I3+UKMBsBwaaHUlf7mqC2dtTTQf1Y2Vqc6+ogJF4RJy2E+LmZ1u+sBpvh+FriTb Gz3C8qLsd7EPk2mWWF/VbHbH7c2hYy2vk7WSyJn3mg7ttzxchc8xxs/vr3yNhP4IqDeW 0xag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741273511; x=1741878311; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0mxhfe662mFKXoNMPrYea9QmFeK+eqDDltOasYkoZcA=; b=Q8dRM4v48hXlpm/jR0m4lAHLXcMOHBMLyTlf8gTuULQ5YuSeCXL0xXsTc7NZOSJHWB 2yAUbvNiGJLE6wkCI172sChXsHbcv2H+uj0LeyUkALauO2VgqxGwg6zSIVHCs3hIXo/G TNHbavtxDoC8IKRNZltDLnlbkv62VcsyMdrDmJZcVhxO1o7TouN83MaM/5Tn3+Yq5aRI O3uVZ5bsE95JtuuZxpeXHAeEO5/sSbBBWq9+MHWCxERR9BaG11oSlR/vBYvCLL3KtoyB DpWzQ0iVCuo3NSQV9xt7pmgpfpttfXJbmRm50FUZQ9Hrjd8GVO4fQmWssnX2bZ+WeSUy Fx9Q== X-Gm-Message-State: AOJu0Yw5+76a9b+zIyxFcHz5O+yCd/eMWPIGLjMeDkSXqOsWGbxPBhIw 00FB1JnfuM13zuRQHJVoGpgmZ0WHfP0uW0LIB7kqAi1xnsDrKWAwTZ8DOhNLzIE= X-Gm-Gg: ASbGnctlYsdBEBeGLvWDt4TF7W4kutxFgpC/JpgUxHGm0cEWBH4t4O1HjZu2eoqCq1m luj8M61n/4w9rpWuli07r41H9IGG9H0n3eGQIVVyio/cVqKfNRLxALmsUAsOnlfS7F2f2BNesw+ 9IpLzEUPX3YXzVV2uBk4Bt33Va0jx2ntNgx2lOLl17Gs7FfAz8wtytpEuvIFGeJYeyodR3Q4Oty 1kUYalUIClStezQnpFXcK0QgWUnZ1scull1ib9oT9x/PL8J6u8FyW7J5OX3aAIPWZe4C/XUo8z6 qQq3me3X36VdMturkjShn2REY0xcuSwQGfpV X-Google-Smtp-Source: AGHT+IEqAuXd7afnd0Dt1HKumrunpDNZSQhc5PKX/Hjsq7JDKDGmQ5oF9rxSxlYeY9IOKZII3LXW2Q== X-Received: by 2002:a05:6602:36c5:b0:85a:f63f:cf06 with SMTP id ca18e2360f4ac-85affb58d03mr901346839f.11.1741273510171; Thu, 06 Mar 2025 07:05:10 -0800 (PST) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-85b11986819sm29718039f.6.2025.03.06.07.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 07:05:09 -0800 (PST) From: Jens Axboe To: song@kernel.org, yukuai3@huawei.com, dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, ira.weiny@intel.com, dlemoal@kernel.org, kch@nvidia.com, yanjun.zhu@linux.dev, hare@suse.de, zhengqixing@huawei.com, colyli@kernel.org, geliang@kernel.org, xni@redhat.com, Zheng Qixing Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, nvdimm@lists.linux.dev, yi.zhang@huawei.com, yangerkun@huawei.com In-Reply-To: <20250227075507.151331-1-zhengqixing@huaweicloud.com> References: <20250227075507.151331-1-zhengqixing@huaweicloud.com> Subject: Re: [PATCH V2 00/12] badblocks: bugfix and cleanup for badblocks Message-Id: <174127350864.65950.963243812292712820.b4-ty@kernel.dk> Date: Thu, 06 Mar 2025 08:05:08 -0700 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3-dev-7b9b9 On Thu, 27 Feb 2025 15:54:55 +0800, Zheng Qixing wrote: > during RAID feature implementation testing, we found several bugs > in badblocks. > > This series contains bugfixes and cleanups for MD RAID badblocks > handling code. > > V2: > - patch 4: add a description of the issue > - patch 5: add comment of parital setting > - patch 6: add fix tag > - patch 10: two code style modifications > - patch 11: keep original functionality of rdev_clear_badblocks(), > functionality was incorrectly modified in V1. > - patch 1-10 and patch 12 are reviewed by Yu Kuai > > - patch 1, 3, 5, 6, 8, 9, 10, 12 are acked by Coly Li > > > [...] Applied, thanks! [01/12] badblocks: Fix error shitf ops commit: 7d83c5d73c1a3c7b71ba70d0ad2ae66e7a0e7ace [02/12] badblocks: factor out a helper try_adjacent_combine commit: 270b68fee9688428e0a98d4a2c3e6d4c434a84ba [03/12] badblocks: attempt to merge adjacent badblocks during ack_all_badblocks commit: 32e9ad4d11f69949ff331e35a417871ee0d31d99 [04/12] badblocks: return error directly when setting badblocks exceeds 512 commit: 28243dcd1f49cc8be398a1396d16a45527882ce5 [05/12] badblocks: return error if any badblock set fails commit: 7f500f0a59b1d7345a05ec4ae703babf34b7e470 [06/12] badblocks: fix the using of MAX_BADBLOCKS commit: 37446680dfbfbba7cbedd680047182f70a0b857b [07/12] badblocks: try can_merge_front before overlap_front commit: 3a23d05f9c1abf8238fe48167ab5574062d1606e [08/12] badblocks: fix merge issue when new badblocks align with pre+1 commit: 9ec65dec634a752ab0a1203510ee190356e4cf1a [09/12] badblocks: fix missing bad blocks on retry in _badblocks_check() commit: 5236f041fa6c81c71eabad44897e54a0d6d5bbf6 [10/12] badblocks: return boolean from badblocks_set() and badblocks_clear() commit: c8775aefba959cdfbaa25408a84d3dd15bbeb991 [11/12] md: improve return types of badblocks handling functions commit: 7e5102dd99f3ad1f981671ad5b4f24ac48c568ad [12/12] badblocks: use sector_t instead of int to avoid truncation of badblocks length commit: d301f164c3fbff611bd71f57dfa553b9219f0f5e Best regards, -- Jens Axboe