From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] block: fix kobject leak in blk_unregister_queue
Date: Fri, 11 Jul 2025 20:40:02 -0600 [thread overview]
Message-ID: <175228800299.1597338.9364384111369193524.b4-ty@kernel.dk> (raw)
In-Reply-To: <20250711083009.2574432-1-ming.lei@redhat.com>
On Fri, 11 Jul 2025 16:30:09 +0800, Ming Lei wrote:
> The kobject for the queue, `disk->queue_kobj`, is initialized with a
> reference count of 1 via `kobject_init()` in `blk_register_queue()`.
> While `kobject_del()` is called during the unregister path to remove
> the kobject from sysfs, the initial reference is never released.
>
> Add a call to `kobject_put()` in `blk_unregister_queue()` to properly
> decrement the reference count and fix the leak.
>
> [...]
Applied, thanks!
[1/1] block: fix kobject leak in blk_unregister_queue
(no commit info)
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-07-12 2:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 8:30 [PATCH] block: fix kobject leak in blk_unregister_queue Ming Lei
2025-07-12 2:40 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175228800299.1597338.9364384111369193524.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox