From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>
Cc: Changhui Zhong <czhong@redhat.com>
Subject: Re: [PATCH] loop: use kiocb helpers to fix lockdep warning
Date: Wed, 16 Jul 2025 06:34:45 -0600 [thread overview]
Message-ID: <175266928564.266324.4332211753512549130.b4-ty@kernel.dk> (raw)
In-Reply-To: <20250716114808.3159657-1-ming.lei@redhat.com>
On Wed, 16 Jul 2025 19:48:08 +0800, Ming Lei wrote:
> The lockdep tool can report a circular lock dependency warning in the loop
> driver's AIO read/write path:
>
> ```
> [ 6540.587728] kworker/u96:5/72779 is trying to acquire lock:
> [ 6540.593856] ff110001b5968440 (sb_writers#9){.+.+}-{0:0}, at: loop_process_work+0x11a/0xf70 [loop]
> [ 6540.603786]
> [ 6540.603786] but task is already holding lock:
> [ 6540.610291] ff110001b5968440 (sb_writers#9){.+.+}-{0:0}, at: loop_process_work+0x11a/0xf70 [loop]
> [ 6540.620210]
> [ 6540.620210] other info that might help us debug this:
> [ 6540.627499] Possible unsafe locking scenario:
> [ 6540.627499]
> [ 6540.634110] CPU0
> [ 6540.636841] ----
> [ 6540.639574] lock(sb_writers#9);
> [ 6540.643281] lock(sb_writers#9);
> [ 6540.646988]
> [ 6540.646988] *** DEADLOCK ***
> ```
>
> [...]
Applied, thanks!
[1/1] loop: use kiocb helpers to fix lockdep warning
commit: c4706c5058a7bd7d7c20f3b24a8f523ecad44e83
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2025-07-16 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 11:48 [PATCH] loop: use kiocb helpers to fix lockdep warning Ming Lei
2025-07-16 12:20 ` Christoph Hellwig
2025-07-16 12:31 ` Ming Lei
2025-07-17 4:31 ` Christoph Hellwig
2025-07-16 12:34 ` Jens Axboe [this message]
2025-07-18 1:22 ` Changhui Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175266928564.266324.4332211753512549130.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=czhong@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox