From: Jens Axboe <axboe@kernel.dk>
To: Jim.Quigley@oracle.com, davem@davemloft.net, sln@onemain.com,
alexandre.chartre@oracle.com, aaron.young@oracle.com,
Ma Ke <make24@iscas.ac.cn>
Cc: akpm@linux-foundation.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] sunvdc: Balance device refcount in vdc_port_mpgroup_check
Date: Tue, 22 Jul 2025 10:02:30 -0600 [thread overview]
Message-ID: <175320015081.186214.5828107139805643955.b4-ty@kernel.dk> (raw)
In-Reply-To: <20250719075856.3447953-1-make24@iscas.ac.cn>
On Sat, 19 Jul 2025 15:58:56 +0800, Ma Ke wrote:
> Using device_find_child() to locate a probed virtual-device-port node
> causes a device refcount imbalance, as device_find_child() internally
> calls get_device() to increment the device’s reference count before
> returning its pointer. vdc_port_mpgroup_check() directly returns true
> upon finding a matching device without releasing the reference via
> put_device(). We should call put_device() to decrement refcount.
>
> [...]
Applied, thanks!
[1/1] sunvdc: Balance device refcount in vdc_port_mpgroup_check
commit: 63ce53724637e2e7ba51fe3a4f78351715049905
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-07-22 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-19 7:58 [PATCH v2] sunvdc: Balance device refcount in vdc_port_mpgroup_check Ma Ke
2025-07-22 16:02 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175320015081.186214.5828107139805643955.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=Jim.Quigley@oracle.com \
--cc=aaron.young@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=alexandre.chartre@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=sln@onemain.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox