From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org, Julian Sun <sunjunchao2870@gmail.com>
Cc: nilay@linux.ibm.com, ming.lei@redhat.com,
Julian Sun <sunjunchao@bytedance.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] block: restore default wbt enablement
Date: Wed, 13 Aug 2025 06:32:19 -0600 [thread overview]
Message-ID: <175508833916.953995.11740099334208966785.b4-ty@kernel.dk> (raw)
In-Reply-To: <20250812154257.57540-1-sunjunchao@bytedance.com>
On Tue, 12 Aug 2025 23:42:57 +0800, Julian Sun wrote:
> The commit 245618f8e45f ("block: protect wbt_lat_usec using
> q->elevator_lock") protected wbt_enable_default() with
> q->elevator_lock; however, it also placed wbt_enable_default()
> before blk_queue_flag_set(QUEUE_FLAG_REGISTERED, q);, resulting
> in wbt failing to be enabled.
>
> Moreover, the protection of wbt_enable_default() by q->elevator_lock
> was removed in commit 78c271344b6f ("block: move wbt_enable_default()
> out of queue freezing from sched ->exit()"), so we can directly fix
> this issue by placing wbt_enable_default() after
> blk_queue_flag_set(QUEUE_FLAG_REGISTERED, q);.
>
> [...]
Applied, thanks!
[1/1] block: restore default wbt enablement
commit: 8f5845e0743bf3512b71b3cb8afe06c192d6acc4
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2025-08-13 12:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 15:42 [PATCH v2] block: restore default wbt enablement Julian Sun
2025-08-13 0:41 ` Ming Lei
2025-08-13 3:27 ` Yu Kuai
2025-08-13 5:03 ` Nilay Shroff
2025-08-13 12:32 ` Jens Axboe [this message]
2025-08-14 8:08 ` kernel test robot
2025-08-14 8:40 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175508833916.953995.11740099334208966785.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nilay@linux.ibm.com \
--cc=stable@vger.kernel.org \
--cc=sunjunchao2870@gmail.com \
--cc=sunjunchao@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox