From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F51E26F467 for ; Thu, 2 Oct 2025 21:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759440606; cv=none; b=JsdnWl6ijIbgf0VA0UzwGjmzsmpq4Ur3anEpm1eGk9a79UmCnVUANViDTUHwMWD70KZ1o8j5leydnZmgGsoeN/cafB2kcMP9KnaovU3PYxNw9gE+aqWzHSDaoVg/zcuzUCDEoV9fHUw+zESREbRypDkfPfw0vC+5lhKrx1+gF48= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759440606; c=relaxed/simple; bh=R7gp+wUEBlsy8TXb5IZ7eoV7BMXWYpGmkv2yG7V6KXA=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=DU4MEmn8BW+e8HkCb5wNx36kI5LAKCTGpjQHbH5QFtg1UefDFchd6hq7I76T2/7EpQ2LWBYWzXUOmqYXQE4abh/COvOpiZAjEnRMfEDsr2wPHjtbfhbUWWYj0691RsbjtdINSiReu145nVL//1RZfgACWNT6PY17tFmvCwKbVyQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=hXJEFJfm; arc=none smtp.client-ip=209.85.166.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="hXJEFJfm" Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-93b9022d037so37116339f.2 for ; Thu, 02 Oct 2025 14:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1759440604; x=1760045404; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qLDl83AHQQg8jNm/Vtit4m6V+8FOHWhqpuduZuJjG4s=; b=hXJEFJfm60Ele7Kye0Urg1vcoLd39tKGflls9bpsBMaNqGYA6KgJAl/YOnyHGhkJFM XTNiH5gMNJw9l3losW05l4dsDWLa3MB4oH3B2ZP10eRQBY9rrA68Mtiz+DRg1kRkcgUA bQC3Gxmk8ZJtV5Qzyk/ogzyGM2dgsY8/1cfW1tHBMqGt/GIZrsV3l4Rc1ZWKfUFfJbNz Eyn0b+8VTuOs14klR/38ABi+2tigNkAOuSvWKyoFFGot6OCEWOE+H0SHW5arhRYxKPGK vDU1LnWqvSyuVp1zP62i2B0uTo0pNmKjwOVtkW7XWGvpYp34U72pvPO7/zersWrMJcJX +TcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759440604; x=1760045404; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qLDl83AHQQg8jNm/Vtit4m6V+8FOHWhqpuduZuJjG4s=; b=Dt95tLloEG1RlHx0eiD4P5+XzV2ELfNI5JpGBcx7mwY+EOGhBCgK37I0eLpg0qyhl5 AkKgAEelYwFiIJ0YIzfG+xMT3DWFKeHJeQeJFg/cr/P1dCP04n0Lm5uHC0WgP2rnN+/f nPr9BW6IyJw+6rPxjdNdDMnKK0PZBcvavgD+7qzHM5GY7rY0QheL+y4lkz0GIhVwtcQi oSr9Chyp9MeiZGGEtH5jifg6eFJWAHC4uvKwJxTFFr13HUX02+Ntz/6vRpf/bJxNPvzs 9u+EqjCK22p3OWmOK8/c14iDel0XfkM71JYWqrfrP924hJkBUBW7+NJHIVAEDryjV3ux AAJA== X-Forwarded-Encrypted: i=1; AJvYcCVTrTcg9+qtVC0QPWviPvpOgsjTN3mIHhLIp6xt9nKSDdUDzcKiQUJSuUh+6hJeH7/Bt4uyPje/Ygs3VA==@vger.kernel.org X-Gm-Message-State: AOJu0YzlbpiOogyTBGVjmxMSUgeVwyvp8t09NUONtqyfbZhyHmEESaak jpkCuNK/TJBDLXQxNTHWsmKXd7xtnkZFbG4Xw1OET3DRnLddXLXSOVaSw7MpceE9Gvw= X-Gm-Gg: ASbGnctzW37xEBhR0NjoB9YrYBD2AxxXSArqw4w4+SXuiEQxQRFRO+v+MVbnBt/wl3E tDHlPYLUdcmtiIdYeUwo9Sga07iKb6IuU7du8f538SDRwJmd0WehcTh1sAPZHrUcZd+OM65QS1V YFxopK6ZKCitp6GSJ6Yh/8qt7pex83ng0/y6Ihb2RvXWkZ3qZfVhiIMNSFQGErEO2VUvg9S9i00 OQBiGHNTP0q0YJUeGwia25Dfr94vMjAHOCwtnUT7Uvj4wya1I+nJg1XqxjEJwaxeNZq2KG3TrR4 G6grGuHOL4oeM16c/OCo7fO29YG0DJT2q/t36ymSunsPdGZs0C1hJODTmeKtf8iUN0iMoobIUy9 jTshYGCakwQE4KTu+rEWGvzID8Xy8K0TsvRFNJF4= X-Google-Smtp-Source: AGHT+IHxY87feeg8VR7DJ57L7THw1pnEuQD0gg/CzqqgunAYZfmnjkB3QilA5ylhsC2jeajxLrkP+A== X-Received: by 2002:a05:6602:29c8:b0:887:4ba9:a0ee with SMTP id ca18e2360f4ac-93b96a59d49mr92375139f.10.1759440604235; Thu, 02 Oct 2025 14:30:04 -0700 (PDT) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-93a7d81bf16sm119168039f.4.2025.10.02.14.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Oct 2025 14:30:03 -0700 (PDT) From: Jens Axboe To: Lizhi Xu , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Li Chen Cc: stable@vger.kernel.org, Markus Elfring , Yang Erkun , Ming Lei , Yu Kuai In-Reply-To: <20250930003559.708798-1-me@linux.beauty> References: <20250930003559.708798-1-me@linux.beauty> Subject: Re: [PATCH v2] loop: fix backing file reference leak on validation error Message-Id: <175944060261.1563810.3419677787520547910.b4-ty@kernel.dk> Date: Thu, 02 Oct 2025 15:30:02 -0600 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 On Tue, 30 Sep 2025 08:35:59 +0800, Li Chen wrote: > loop_change_fd() and loop_configure() call loop_check_backing_file() > to validate the new backing file. If validation fails, the reference > acquired by fget() was not dropped, leaking a file reference. > > Fix this by calling fput(file) before returning the error. > > > [...] Applied, thanks! [1/1] loop: fix backing file reference leak on validation error commit: 98b7bf54338b797e3a11e8178ce0e806060d8fa3 Best regards, -- Jens Axboe