From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bartlomiej Zolnierkiewicz To: Christoph Hellwig Cc: axboe@kernel.dk, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 2/3] ide-pm: always pass 0 error to __blk_end_request_all Date: Wed, 26 Apr 2017 12:32:49 +0200 Message-id: <1767347.L1Lf3WVO5M@amdc3058> In-reply-to: <20170426073422.14511-3-hch@lst.de> MIME-version: 1.0 Content-type: text/plain; charset="us-ascii" References: <20170426073422.14511-1-hch@lst.de> <20170426073422.14511-3-hch@lst.de> List-ID: On Wednesday, April 26, 2017 09:34:21 AM Christoph Hellwig wrote: > ide_pm_execute_rq exectures a PM request synchronously, and in the failure > case where it calls __blk_end_request_all it never checks the error field > passed to the end_io callback, so don't bother setting it. > > Signed-off-by: Christoph Hellwig Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics