From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org, Ming Lei <tom.leiming@gmail.com>
Cc: Caleb Sander Mateos <csander@purestorage.com>,
Uday Shankar <ushankar@purestorage.com>
Subject: Re: [PATCH] ublk: don't issue uring_cmd from fallback task work
Date: Fri, 01 May 2026 05:31:09 -0600 [thread overview]
Message-ID: <177763506987.181772.6728415392389170664.b4-ty@b4> (raw)
In-Reply-To: <20260501112312.947327-1-tom.leiming@gmail.com>
On Fri, 01 May 2026 19:23:12 +0800, Ming Lei wrote:
> When ublk_ch_uring_cmd_cb() runs as fallback task work (e.g., because
> the submitting task is exiting), the command should not be issued as
> current is a kworker, not the daemon task. This can cause io->task
> to capture the wrong task in __ublk_fetch(), leading to a task
> mismatch warning in ublk_uring_cmd_cancel_fn().
>
> Check tw.cancel and return -ECANCELED instead of issuing the command
> from fallback context.
>
> [...]
Applied, thanks!
[1/1] ublk: don't issue uring_cmd from fallback task work
commit: 845db023a8aeba8b14315a846dcfba31ee727fb1
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2026-05-01 11:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 11:23 [PATCH] ublk: don't issue uring_cmd from fallback task work Ming Lei
2026-05-01 11:31 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177763506987.181772.6728415392389170664.b4-ty@b4 \
--to=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=linux-block@vger.kernel.org \
--cc=tom.leiming@gmail.com \
--cc=ushankar@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox