From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <tom.leiming@gmail.com>,
Yousef Alhouseen <alhouseenyousef@gmail.com>
Cc: Caleb Sander Mateos <csander@purestorage.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+1a67ee1aa79484801ec6@syzkaller.appspotmail.com
Subject: Re: [PATCH] ublk: snapshot batch commands before preparing I/O
Date: Thu, 02 Jul 2026 06:28:40 -0600 [thread overview]
Message-ID: <178299532009.108615.15257400425085643970.b4-ty@b4> (raw)
In-Reply-To: <20260630211827.50475-1-alhouseenyousef@gmail.com>
On Tue, 30 Jun 2026 23:18:27 +0200, Yousef Alhouseen wrote:
> The batch prepare path rereads its userspace element array when rolling
> back a partially prepared batch. Userspace can change an already
> processed tag before the second read, causing rollback to reject the
> replacement tag and leave earlier I/O slots prepared. The
> WARN_ON_ONCE() in the rollback path then fires.
>
> Copy the bounded batch into kernel memory before changing any I/O state
> and use the same snapshot for preparation and rollback. Commit and fetch
> batches retain the existing chunked userspace walk.
>
> [...]
Applied, thanks!
[1/1] ublk: snapshot batch commands before preparing I/O
commit: f01f5275feb77bac9fefbbf7cc584fe0b3850a92
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2026-07-02 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 21:18 [PATCH] ublk: snapshot batch commands before preparing I/O Yousef Alhouseen
2026-07-02 11:53 ` Ming Lei
2026-07-02 12:28 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178299532009.108615.15257400425085643970.b4-ty@b4 \
--to=axboe@kernel.dk \
--cc=alhouseenyousef@gmail.com \
--cc=csander@purestorage.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+1a67ee1aa79484801ec6@syzkaller.appspotmail.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox