From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Wenchao Hao <haowenchao@huawei.com>,
syzkaller-bugs@googlegroups.com,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: axboe@kernel.dk, jejb@linux.ibm.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com,
syzbot+f08c77040fa163a75a46@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com, linfeilong@huawei.com
Subject: Re: [PATCH] scsi: sd: call device_del() if device_add_disk() fails
Date: Thu, 31 Mar 2022 18:14:27 +0200 [thread overview]
Message-ID: <1787706.atdPhlSkOF@leap> (raw)
In-Reply-To: <20220331134210.GF12805@kadam>
On gioved? 31 marzo 2022 15:42:10 CEST Dan Carpenter wrote:
> Wenchao Hao, what you're saying makes a lot of sense but it raises a lot
> of questions in turn.
>
> Fabio, did you test your patch?
Yes, I did, Dan. I tested it the usual way with the "#syz test:" command.
Obviously I have not the hardware to test code on it.
Therefore, the messages that say "Syzbot tested the patch and it didn't
trigger any issue" is all that I can know about the code being good or not.
This is the criterion I've always used before sending patches for Syzbot's
reports.
However, my knowledge of these subsystems and the API that are related to
this bug were very little, but now I can say that during the last couple of
days it has improved to the point where I can affirm that Wenchao's patch
seems to me to be the only correct solution.
Thanks for all the help you and the the other developers provided. It was
invaluable for a better understanding of this matter.
Regards,
Fabio M. De Francesco
next prev parent reply other threads:[~2022-03-31 16:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 15:49 [PATCH] scsi: sd: call device_del() if device_add_disk() fails Fabio M. De Francesco
2022-03-30 4:30 ` Dan Carpenter
2022-03-31 15:26 ` Wenchao Hao
2022-03-31 5:41 ` Dan Carpenter
2022-03-31 5:45 ` Christoph Hellwig
2022-03-31 9:07 ` Fabio M. De Francesco
2022-03-31 9:13 ` Christoph Hellwig
2022-03-31 10:13 ` Fabio M. De Francesco
2022-03-31 12:14 ` Wenchao Hao
2022-03-31 13:42 ` Dan Carpenter
2022-03-31 14:19 ` James Bottomley
2022-03-31 15:11 ` Dan Carpenter
2022-03-31 16:14 ` Fabio M. De Francesco [this message]
2022-03-31 16:24 ` Dan Carpenter
2022-03-31 17:21 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1787706.atdPhlSkOF@leap \
--to=fmdefrancesco@gmail.com \
--cc=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=haowenchao@huawei.com \
--cc=jejb@linux.ibm.com \
--cc=linfeilong@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=syzbot+f08c77040fa163a75a46@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).