From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Nilay Shroff <nilay@linux.ibm.com>
Subject: Re: [PATCH] block: Move a misplaced comment in queue_wb_lat_store()
Date: Mon, 25 Aug 2025 08:08:47 -0700 [thread overview]
Message-ID: <17b4a517-c35a-412b-843d-e9ee47b12370@acm.org> (raw)
In-Reply-To: <61bf6a0f-05de-44c6-b4eb-87254fca4d24@kernel.dk>
On 8/25/25 6:48 AM, Jens Axboe wrote:
> On Fri, Aug 22, 2025 at 2:02?PM Bart Van Assche <bvanassche@acm.org> wrote:
>> blk_mq_quiesce_queue() does not wait for pending I/O to finish. Freezing
>> a queue waits for pending I/O to finish. Hence move the comment that
>> refers to waiting for pending I/O above the call that freezes the
>> request queue. This patch moves this comment back to the position where
>> it was when this comment was introduced. See also commit c125311d96b1
>> ("blk-wbt: don't maintain inflight counts if disabled").
>
> Doesn't apply to the current tree, what is this against?
These patches are in my local tree and are causing the failure to apply:
"[PATCH 0/3] Fix a deadlock related to modifying queue attributes"
(https://lore.kernel.org/linux-block/20250702182430.3764163-1-bvanassche@acm.org/).
I should have removed these from my local tree
before I posted this patch.
> In any case, please resend.
Sure, I will do that.
Thanks,
Bart.
prev parent reply other threads:[~2025-08-25 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 20:01 [PATCH] block: Move a misplaced comment in queue_wb_lat_store() Bart Van Assche
2025-08-25 2:40 ` Nilay Shroff
2025-08-25 13:48 ` Jens Axboe
2025-08-25 15:08 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17b4a517-c35a-412b-843d-e9ee47b12370@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).