Linux block layer
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Cc: Kanchan Joshi <joshi.k@samsung.com>, linux-block@vger.kernel.org
Subject: Re: [PATCH for-next] nvme: use helpers to access io_uring cmd space
Date: Fri, 18 Oct 2024 12:37:40 -0600	[thread overview]
Message-ID: <17db11b6-16aa-499e-ad2a-da0575aaf334@kernel.dk> (raw)
In-Reply-To: <c274d35f441c649f0b725c70f681ec63774fce3b.1729265044.git.asml.silence@gmail.com>

On 10/18/24 10:16 AM, Pavel Begunkov wrote:
> Command implementations shouldn't be directly looking into io_uring_cmd
> to carve free space. Use an io_uring helper, which will also do build
> time size sanitisation.

Reviewed-by: Jens Axboe <axboe@kernel.dk>

-- 
Jens Axboe


  reply	other threads:[~2024-10-18 18:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20241018161636epcas5p43562d1c949f7e6ed0289a7ec213490ff@epcas5p4.samsung.com>
2024-10-18 16:16 ` [PATCH for-next] nvme: use helpers to access io_uring cmd space Pavel Begunkov
2024-10-18 18:37   ` Jens Axboe [this message]
2024-10-18 18:43   ` Anuj gupta
2024-10-19  0:44   ` Chaitanya Kulkarni
2024-10-21 16:04     ` Pavel Begunkov
2024-10-21  3:53   ` Kanchan Joshi
2024-10-21 15:16   ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17db11b6-16aa-499e-ad2a-da0575aaf334@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asml.silence@gmail.com \
    --cc=io-uring@vger.kernel.org \
    --cc=joshi.k@samsung.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox