From: Jens Axboe <axboe@kernel.dk>
To: Liu Bo <bo.liu@linux.alibaba.com>, linux-block@vger.kernel.org
Subject: Re: [PATCH] Block: initialize bio_cnt_ret_time for the first time
Date: Fri, 29 Jun 2018 14:00:01 -0600 [thread overview]
Message-ID: <17ed5986-02c8-42be-f832-04594a3bc202@kernel.dk> (raw)
In-Reply-To: <1529550424-105210-1-git-send-email-bo.liu@linux.alibaba.com>
On 6/20/18 9:07 PM, Liu Bo wrote:
> When a new tg is created, tg->bio_cnt_ret_time is 0, so if the first
> IO going thru this tg turns out to be a bad one, we fail to record it
> in tg->bad_bio_cnt as
>
> if (jiffies > bio_cnt_ret_time) {
> tg->bad_bio_cnt /= 2;
> }
Shouldn't we rather ensure that ->bio_cnt_ret_time is initialized to
jiffies?
--
Jens Axboe
next prev parent reply other threads:[~2018-06-29 20:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 3:07 [PATCH] Block: initialize bio_cnt_ret_time for the first time Liu Bo
2018-06-29 19:50 ` Liu Bo
2018-06-29 20:00 ` Jens Axboe [this message]
2018-06-29 20:23 ` Liu Bo
2018-06-29 20:26 ` Jens Axboe
2018-06-29 20:43 ` Liu Bo
2018-06-29 20:46 ` Jens Axboe
2018-06-29 21:41 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17ed5986-02c8-42be-f832-04594a3bc202@kernel.dk \
--to=axboe@kernel.dk \
--cc=bo.liu@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox