From: Max Gurtovoy <maxg@mellanox.com>
To: Keith Busch <keith.busch@intel.com>,
<linux-nvme@lists.infradead.org>, <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>
Cc: Ming Lei <minlei@redhat.com>
Subject: Re: [PATCH] blk-mq: Fix queue usage on failed request allocation
Date: Tue, 15 Aug 2017 14:58:35 +0300 [thread overview]
Message-ID: <1810fc11-5199-977c-4505-eece5d2fa44d@mellanox.com> (raw)
In-Reply-To: <1502743211-14992-1-git-send-email-keith.busch@intel.com>
On 8/14/2017 11:40 PM, Keith Busch wrote:
> blk_mq_get_request() does not release the callers queue usage counter
> when allocation fails. The caller still needs to account for its own
> queue usage when it is unable to allocate a request.
>
> Fixes: 1ad43c0078b7 ("blk-mq: don't leak preempt counter/q_usage_counter when allocating rq failed")
>
> Reported-by: Max Gurtovoy <maxg@mellanox.com>
> Signed-off-by: Keith Busch <keith.busch@intel.com>
> ---
tested with 4.13-rc5+ using the following commands in a loop:
1. modprobe nvme
2. sleep 10
3. modprobe -r nvme
Looks good,
Tested-by: Max Gurtovoy <maxg@mellanox.com>
next prev parent reply other threads:[~2017-08-15 11:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 20:40 [PATCH] blk-mq: Fix queue usage on failed request allocation Keith Busch
2017-08-15 2:46 ` Ming Lei
2017-08-15 9:53 ` Sagi Grimberg
2017-08-15 11:58 ` Max Gurtovoy [this message]
2017-08-15 13:22 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1810fc11-5199-977c-4505-eece5d2fa44d@mellanox.com \
--to=maxg@mellanox.com \
--cc=axboe@kernel.dk \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=minlei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox