* [PATCH] block: remove useless req addr print in debugfs
@ 2025-03-12 8:47 Guixin Liu
2025-03-14 3:04 ` Guixin Liu
0 siblings, 1 reply; 3+ messages in thread
From: Guixin Liu @ 2025-03-12 8:47 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block
Using %p to print kernel address will only print a hashed address
which is not the real address, this is useless for issue
identification, simply remove it.
Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
---
block/blk-mq-debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index adf5f0697b6b..b4da95150d8d 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -265,7 +265,7 @@ int __blk_mq_debugfs_rq_show(struct seq_file *m, struct request *rq)
BUILD_BUG_ON(ARRAY_SIZE(cmd_flag_name) != __REQ_NR_BITS);
BUILD_BUG_ON(ARRAY_SIZE(rqf_name) != __RQF_BITS);
- seq_printf(m, "%p {.op=", rq);
+ seq_printf(m, "{.op=");
if (strcmp(op_str, "UNKNOWN") == 0)
seq_printf(m, "%u", op);
else
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] block: remove useless req addr print in debugfs
2025-03-12 8:47 [PATCH] block: remove useless req addr print in debugfs Guixin Liu
@ 2025-03-14 3:04 ` Guixin Liu
2025-03-14 14:54 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Guixin Liu @ 2025-03-14 3:04 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block
Gently ping...
Best Regards,
Guixin Liu
在 2025/3/12 16:47, Guixin Liu 写道:
> Using %p to print kernel address will only print a hashed address
> which is not the real address, this is useless for issue
> identification, simply remove it.
>
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> ---
> block/blk-mq-debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
> index adf5f0697b6b..b4da95150d8d 100644
> --- a/block/blk-mq-debugfs.c
> +++ b/block/blk-mq-debugfs.c
> @@ -265,7 +265,7 @@ int __blk_mq_debugfs_rq_show(struct seq_file *m, struct request *rq)
> BUILD_BUG_ON(ARRAY_SIZE(cmd_flag_name) != __REQ_NR_BITS);
> BUILD_BUG_ON(ARRAY_SIZE(rqf_name) != __RQF_BITS);
>
> - seq_printf(m, "%p {.op=", rq);
> + seq_printf(m, "{.op=");
> if (strcmp(op_str, "UNKNOWN") == 0)
> seq_printf(m, "%u", op);
> else
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] block: remove useless req addr print in debugfs
2025-03-14 3:04 ` Guixin Liu
@ 2025-03-14 14:54 ` Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2025-03-14 14:54 UTC (permalink / raw)
To: Guixin Liu; +Cc: linux-block
On 3/13/25 9:04 PM, Guixin Liu wrote:
> Gently ping...
Don't send a ping after 1 day, that's totally unnecessary. Especially
for a patch that isn't an urgent fix, it's just an odd ball cleanup.
Reviewers have more important things to look at, and we'll get to yours
in due time.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-14 14:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-12 8:47 [PATCH] block: remove useless req addr print in debugfs Guixin Liu
2025-03-14 3:04 ` Guixin Liu
2025-03-14 14:54 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox