* [RFC PATCH v1 1/2] block: bsg: resume scsi device before accessing
[not found] <cover.1611719814.git.asutoshd@codeaurora.org>
@ 2021-01-27 4:00 ` Asutosh Das
2021-01-27 7:09 ` Avri Altman
2021-02-07 2:23 ` Bart Van Assche
2021-01-28 3:26 ` [RFC PATCH v2 1/2] block: bsg: resume platform " Asutosh Das
1 sibling, 2 replies; 6+ messages in thread
From: Asutosh Das @ 2021-01-27 4:00 UTC (permalink / raw)
To: cang, martin.petersen, linux-scsi
Cc: Asutosh Das, linux-arm-msm, stern, Bao D . Nguyen,
FUJITA Tomonori, Jens Axboe, open list:BLOCK LAYER, open list
Resumes the scsi device before accessing it.
Change-Id: I2929af60f2a92c89704a582fcdb285d35b429fde
Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
Signed-off-by: Can Guo <cang@codeaurora.org>
Signed-off-by: Bao D. Nguyen <nguyenb@codeaurora.org>
---
block/bsg.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/block/bsg.c b/block/bsg.c
index d7bae94..f4c197f 100644
--- a/block/bsg.c
+++ b/block/bsg.c
@@ -306,12 +306,16 @@ static struct bsg_device *bsg_get_device(struct inode *inode, struct file *file)
static int bsg_open(struct inode *inode, struct file *file)
{
struct bsg_device *bd;
+ struct scsi_device *sd;
bd = bsg_get_device(inode, file);
if (IS_ERR(bd))
return PTR_ERR(bd);
+ sd = (struct scsi_device *) bd->queue->queuedata;
+ if (scsi_autopm_get_device(sd))
+ return -EIO;
file->private_data = bd;
return 0;
}
@@ -319,8 +323,12 @@ static int bsg_open(struct inode *inode, struct file *file)
static int bsg_release(struct inode *inode, struct file *file)
{
struct bsg_device *bd = file->private_data;
+ struct scsi_device *sd;
file->private_data = NULL;
+ sd = (struct scsi_device *) bd->queue->queuedata;
+ scsi_autopm_put_device(sd);
+
return bsg_put_device(bd);
}
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [RFC PATCH v1 1/2] block: bsg: resume scsi device before accessing
2021-01-27 4:00 ` [RFC PATCH v1 1/2] block: bsg: resume scsi device before accessing Asutosh Das
@ 2021-01-27 7:09 ` Avri Altman
2021-01-27 7:59 ` Can Guo
2021-02-07 2:23 ` Bart Van Assche
1 sibling, 1 reply; 6+ messages in thread
From: Avri Altman @ 2021-01-27 7:09 UTC (permalink / raw)
To: Asutosh Das, cang@codeaurora.org, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, stern@rowland.harvard.edu,
Bao D . Nguyen, FUJITA Tomonori, Jens Axboe,
open list:BLOCK LAYER, open list
>
> Resumes the scsi device before accessing it.
>
> Change-Id: I2929af60f2a92c89704a582fcdb285d35b429fde
> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> Signed-off-by: Bao D. Nguyen <nguyenb@codeaurora.org>
Following this patch, is it possible to revert commit 74e5e468b664d?
Thanks,
Avri
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH v1 1/2] block: bsg: resume scsi device before accessing
2021-01-27 7:09 ` Avri Altman
@ 2021-01-27 7:59 ` Can Guo
2021-01-27 8:53 ` Can Guo
0 siblings, 1 reply; 6+ messages in thread
From: Can Guo @ 2021-01-27 7:59 UTC (permalink / raw)
To: Avri Altman
Cc: Asutosh Das, martin.petersen, linux-scsi, linux-arm-msm, stern,
Bao D . Nguyen, FUJITA Tomonori, Jens Axboe,
open list:BLOCK LAYER, open list
On 2021-01-27 15:09, Avri Altman wrote:
>>
>> Resumes the scsi device before accessing it.
>>
>> Change-Id: I2929af60f2a92c89704a582fcdb285d35b429fde
>> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
>> Signed-off-by: Can Guo <cang@codeaurora.org>
>> Signed-off-by: Bao D. Nguyen <nguyenb@codeaurora.org>
> Following this patch, is it possible to revert commit 74e5e468b664d?
>
No, but this is a good finding... This change assumes
that the queue->queue_data is a scsi_device, which is
why we call scsi_auto_pm_get(). But for ufs_bsg's case,
queue->queue_data is a device...
Thanks,
Can Guo.
> Thanks,
> Avri
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH v1 1/2] block: bsg: resume scsi device before accessing
2021-01-27 7:59 ` Can Guo
@ 2021-01-27 8:53 ` Can Guo
0 siblings, 0 replies; 6+ messages in thread
From: Can Guo @ 2021-01-27 8:53 UTC (permalink / raw)
To: Avri Altman
Cc: Asutosh Das, martin.petersen, linux-scsi, linux-arm-msm, stern,
Bao D . Nguyen, FUJITA Tomonori, Jens Axboe,
open list:BLOCK LAYER, open list
On 2021-01-27 15:59, Can Guo wrote:
> On 2021-01-27 15:09, Avri Altman wrote:
>>>
>>> Resumes the scsi device before accessing it.
>>>
>>> Change-Id: I2929af60f2a92c89704a582fcdb285d35b429fde
>>> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
>>> Signed-off-by: Can Guo <cang@codeaurora.org>
>>> Signed-off-by: Bao D. Nguyen <nguyenb@codeaurora.org>
>> Following this patch, is it possible to revert commit 74e5e468b664d?
>>
>
> No, but this is a good finding... This change assumes
> that the queue->queue_data is a scsi_device, which is
> why we call scsi_auto_pm_get(). But for ufs_bsg's case,
> queue->queue_data is a device...
>
If we call pm_runtime_get/put_sync(bcd->class_dev->parent) in
bsg_get/put_device(), commit 74e5e468b664d can be reverted.
This is just a rough idea.
> Thanks,
> Can Guo.
>
>> Thanks,
>> Avri
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFC PATCH v2 1/2] block: bsg: resume platform device before accessing
[not found] <cover.1611719814.git.asutoshd@codeaurora.org>
2021-01-27 4:00 ` [RFC PATCH v1 1/2] block: bsg: resume scsi device before accessing Asutosh Das
@ 2021-01-28 3:26 ` Asutosh Das
1 sibling, 0 replies; 6+ messages in thread
From: Asutosh Das @ 2021-01-28 3:26 UTC (permalink / raw)
To: cang, martin.petersen, linux-scsi
Cc: Asutosh Das, linux-arm-msm, stern, Bao D . Nguyen,
FUJITA Tomonori, Jens Axboe, open list:BLOCK LAYER, open list
It may happen that the underlying device's runtime-pm is
not controlled by block-pm. So it's possible that when
commands are sent to the device, it's suspended and may not
be resumed by blk-pm. Hence explicitly resume the parent
which is the platform device.
Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
Signed-off-by: Can Guo <cang@codeaurora.org>
Signed-off-by: Bao D. Nguyen <nguyenb@codeaurora.org>
---
block/bsg.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/block/bsg.c b/block/bsg.c
index d7bae94..e9fc896 100644
--- a/block/bsg.c
+++ b/block/bsg.c
@@ -12,6 +12,7 @@
#include <linux/idr.h>
#include <linux/bsg.h>
#include <linux/slab.h>
+#include <linux/pm_runtime.h>
#include <scsi/scsi.h>
#include <scsi/scsi_ioctl.h>
@@ -306,12 +307,15 @@ static struct bsg_device *bsg_get_device(struct inode *inode, struct file *file)
static int bsg_open(struct inode *inode, struct file *file)
{
struct bsg_device *bd;
+ struct bsg_class_device *bcd;
bd = bsg_get_device(inode, file);
if (IS_ERR(bd))
return PTR_ERR(bd);
+ bcd = &bd->queue->bsg_dev;
+ pm_runtime_get_sync(bcd->class_dev->parent);
file->private_data = bd;
return 0;
}
@@ -319,8 +323,12 @@ static int bsg_open(struct inode *inode, struct file *file)
static int bsg_release(struct inode *inode, struct file *file)
{
struct bsg_device *bd = file->private_data;
+ struct bsg_class_device *bcd;
file->private_data = NULL;
+
+ bcd = &bd->queue->bsg_dev;
+ pm_runtime_put_sync(bcd->class_dev->parent);
return bsg_put_device(bd);
}
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFC PATCH v1 1/2] block: bsg: resume scsi device before accessing
2021-01-27 4:00 ` [RFC PATCH v1 1/2] block: bsg: resume scsi device before accessing Asutosh Das
2021-01-27 7:09 ` Avri Altman
@ 2021-02-07 2:23 ` Bart Van Assche
1 sibling, 0 replies; 6+ messages in thread
From: Bart Van Assche @ 2021-02-07 2:23 UTC (permalink / raw)
To: Asutosh Das, cang, martin.petersen, linux-scsi
Cc: linux-arm-msm, stern, Bao D . Nguyen, FUJITA Tomonori, Jens Axboe,
open list:BLOCK LAYER, open list
On 1/26/21 8:00 PM, Asutosh Das wrote:
> Resumes the scsi device before accessing it.
>
> Change-Id: I2929af60f2a92c89704a582fcdb285d35b429fde
> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> Signed-off-by: Bao D. Nguyen <nguyenb@codeaurora.org>
No Change-Id tags in upstream patches please.
Thanks,
Bart.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-07 2:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1611719814.git.asutoshd@codeaurora.org>
2021-01-27 4:00 ` [RFC PATCH v1 1/2] block: bsg: resume scsi device before accessing Asutosh Das
2021-01-27 7:09 ` Avri Altman
2021-01-27 7:59 ` Can Guo
2021-01-27 8:53 ` Can Guo
2021-02-07 2:23 ` Bart Van Assche
2021-01-28 3:26 ` [RFC PATCH v2 1/2] block: bsg: resume platform " Asutosh Das
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).